Ticket #1001 (closed patch: done)

Opened 5 years ago

Last modified 5 years ago

Dead code in Boolean instantiate

Reported by: flh Owned by:
Priority: normal Milestone:
Component: none Version: trunk
Severity: medium Keywords:
Cc: Language:
Patch status: applied Platform: all

Description

According to make cover, the instantiate VTABLE method of the Boolean PMC is dead code. Actually, it's not even clear if it could be supposed to work.

The attached patch removes this method. It adds an init_pmc method and tests it.

Attachments

boolean_dead_instantiate.patch Download (1.8 KB) - added by flh 5 years ago.

Change History

Changed 5 years ago by flh

Changed 5 years ago by bacek

  • status changed from new to closed
  • resolution set to done
  • patch changed from new to applied

Applied at r41227. Thank!

Changed 5 years ago by bacek

BTW, all other "instantiate" except Class, Object and Default PMCs can be ripped-off as well.

Note: See TracTickets for help on using tickets.