Ticket #1008 (closed bug: fixed)

Opened 12 years ago

Last modified 12 years ago

continuation mark function marks non pobj PackFile_ByteCode *seg

Reported by: jessevdam Owned by:
Priority: normal Milestone:
Component: core Version: 1.5.0
Severity: medium Keywords: continuation mark pobj
Cc: Language:
Patch status: applied Platform: all

Description

The continuation mark function marks(Parrot_gc_mark_PObj_alive) a non pobj. The ATTR seg is a PackFile_ByteCode which is not a pmc.

I added patch which removes the specific mark, but I do not know whether there are any memory leaks or other problems.

I also added a patch which allows you to check whether any non pobj are passed into the gc function which expects pobj objects. I ran the test on r41260 and did not find any other non pobj being but into the gc functions.

Attachments

continuationmarkfix.patch Download (0.7 KB) - added by jessevdam 12 years ago.
unchecked fix for faulty mark in continuation.pmc
isobjcheck.patch Download (7.3 KB) - added by jessevdam 12 years ago.
checking for pobj

Change History

Changed 12 years ago by jessevdam

unchecked fix for faulty mark in continuation.pmc

Changed 12 years ago by jessevdam

checking for pobj

Changed 12 years ago by NotFound

No need to keep the comment, when packfile segments becomes gcable, all usages will be reviewed anyway.

Deleted the mark in r41262, thanks!

Changed 12 years ago by bacek

  • status changed from new to closed
  • resolution set to fixed
  • patch changed from new to applied

Patch applied. Resolving ticket.

Note: See TracTickets for help on using tickets.