Ticket #1047 (closed cage: fixed)

Opened 5 years ago

Last modified 3 years ago

pf_items assumes sizeof(INTVAL) == sizeof(opcode_t)

Reported by: doughera Owned by: jkeenan
Priority: normal Milestone:
Component: configure Version: 1.6.0
Severity: medium Keywords:
Cc: cotto, whiteknight Language:
Patch status: applied Platform:

Description

Parrot's internals assume sizeof(INTVAL) == sizeof(opcode_t) , but Configure.pl allows the user to choose separate sizes for them. Although the two "types" have logically different purposes, and, in principle, need not have the same size, there seems to be no compelling reason to make them different. Thus it probably makes sense to simply require them to be the same at the Configure.pl level.

See  Original RT for more details.

Attachments

tt1047.diff Download (1.3 KB) - added by jkeenan 3 years ago.
diff of work done to date in tt1047/type_sizes branch

Change History

Changed 3 years ago by jkeenan

diff of work done to date in tt1047/type_sizes branch

follow-up: ↓ 2   Changed 3 years ago by jkeenan

  • status changed from new to assigned
  • cc cotto, whiteknight added
  • patch set to new
  • owner set to jkeenan
  • summary changed from [CAGE] pf_items assumes sizeof(INTVAL) == sizeof(opcode_t) to pf_items assumes sizeof(INTVAL) == sizeof(opcode_t)
  • type changed from bug to cage

I have created the tt1047/type_sizes branch to work on this ticket.

I believe the patch attached, tt1047.diff, would satisfy the recommendations in this ticket. Patch passes make test and make fulltest.

Please review. If we like it, I propose to merge it into master after the 3.6 release on July 19.

Thank you very much.

kid51

in reply to: ↑ 1 ; follow-up: ↓ 3   Changed 3 years ago by jkeenan

  • patch changed from new to applied

Replying to jkeenan:

Please review. If we like it, I propose to merge it into master after the 3.6 release on July 19.

Done in cb9e9b896. I will keep ticket open for 7 days for comments or complaints.

Thank you very much.

kid51

in reply to: ↑ 2   Changed 3 years ago by jkeenan

  • status changed from assigned to closed
  • resolution set to fixed

Replying to jkeenan:

Replying to jkeenan:

Please review. If we like it, I propose to merge it into master after the 3.6 release on July 19.

Done in cb9e9b896. I will keep ticket open for 7 days for comments or complaints.

No complaints received. Closing ticket.

Note: See TracTickets for help on using tickets.