Ticket #1072 (closed RFC: fixed)

Opened 5 years ago

Last modified 5 years ago

deprecate vtable function instantiate_str

Reported by: jessevdam Owned by:
Priority: normal Milestone:
Component: core Version: 1.6.0
Severity: medium Keywords: deprecate instantiate_str
Cc: Language:
Patch status: Platform: all

Description (last modified by jkeenan) (diff)

The instantiate_str is only implemented by float.pmc, integer.pmc, fixedintegerarray.pmc and string.pmc.

It is only used by imcc/pbc.c make_pmc_const and src/dynext.c make_string_pmc.

So I think it would be good idea to move this functionality to pbc.c and dynext.c by a small change and then completely remove this instantiate_str vtable function.

Change History

Changed 5 years ago by darbelo

Looking at DEPRECATED.pod you'll see:

=item VTABLE nomenclature. [eligible in 1.5]

Current list of VTABLE functions will be reviewed and cleaned.

L<https://trac.parrot.org/parrot/ticket/866>

Which is a wide enough statement to cover this removal. If anyone cares to +1 this I'll JFDI.

Changed 5 years ago by bacek

+1 as of original author of #866 :)

Changed 5 years ago by julian.notfound@…

>  Which is a wide enough statement to cover this removal. If anyone cares to
>  +1 this I'll JFDI.

+1

-- 
Salu2

Changed 5 years ago by jkeenan

  • description modified (diff)

Changed 5 years ago by darbelo

  • status changed from new to closed
  • resolution set to fixed

Done in r42279. Resolving ticket as fixed.

Note: See TracTickets for help on using tickets.