Ticket #108 (closed RFC: fixed)

Opened 6 years ago

Last modified 5 years ago

remove Data::Replace?

Reported by: coke Owned by: jkeenan
Priority: normal Milestone: 1.5
Component: library Version:
Severity: medium Keywords:
Cc: jkeen@… Language:
Patch status: applied Platform:

Description

This library isn't tested at all, and doesn't appear to be used in the repository.

(It also seems to be conceptually replaced by TGE, though that's a bigger hammer.)

Attachments

remove.Data.Replace.patch Download (7.2 KB) - added by jkeenan 6 years ago.
2nd version of patch

Change History

  Changed 6 years ago by coke

  • component changed from none to library

  Changed 6 years ago by barney

+0 This sort of module would be a candidate for a CPAN for PIR.

  Changed 6 years ago by coke

  • summary changed from remove Data::Replace to remove Data::Replace?

  Changed 6 years ago by jkeenan

Patch submitted -- but Cygwin aspects should be double checked.

follow-up: ↓ 6   Changed 6 years ago by coke

Note, this item wasn't added to the DEPRECATION list. if we want it out before 1.0, we need to put it in the list for the 0.9.1 release.

Jim: don't pull it out of the cygwin patch files. Those are for installing an older version of parrot for which the file did exist.

in reply to: ↑ 5   Changed 6 years ago by jkeenan

Replying to coke:

Jim: don't pull it out of the cygwin patch files. Those are for installing an older version of parrot for which the file did exist.

Providing replacement patch, but taking no other action.

Changed 6 years ago by jkeenan

2nd version of patch

  Changed 6 years ago by jkeenan

Can someone evaluate whether this patch is now applicable?

Thank you very much.
kid51

follow-ups: ↓ 9 ↓ 10   Changed 6 years ago by coke

The ticket wasn't added to DEPRECATED.pod so we still can't apply it.

in reply to: ↑ 8   Changed 6 years ago by coke

Replying to coke:

The ticket wasn't added to DEPRECATED.pod so we still can't apply it.

That is, "before the 0.9.1 release."

in reply to: ↑ 8   Changed 5 years ago by jkeenan

  • cc jkeen@… added

Replying to coke:

The ticket wasn't added to DEPRECATED.pod so we still can't apply it.

Coke: I still don't see this in DEPRECATED.pod. Is it safe to assume that the patch is still not applicable?

Thank you very much.
kid51

follow-up: ↓ 12   Changed 5 years ago by coke

Correct; Now that it's made it into a public release without a notice, if we add a notice now, it's not eligible to be removed until 1.5.

in reply to: ↑ 11 ; follow-up: ↓ 15   Changed 5 years ago by jkeenan

Replying to coke:

Correct; Now that it's made it into a public release without a notice, if we add a notice now, it's not eligible to be removed until 1.5.

Coke added notice to DEPRECATED.pod in r37629. So I'll apply patch after 1.5 is released.

  Changed 5 years ago by jkeenan

  • status changed from new to assigned
  • owner set to jkeenan

  Changed 5 years ago by jkeenan

  • milestone set to 1.5

in reply to: ↑ 12   Changed 5 years ago by jkeenan

  • status changed from assigned to closed
  • resolution set to fixed
  • patch set to applied

Replying to jkeenan:

Replying to coke:

Correct; Now that it's made it into a public release without a notice, if we add a notice now, it's not eligible to be removed until 1.5.

Coke added notice to DEPRECATED.pod in r37629. So I'll apply patch after 1.5 is released.

The deprecation point having passed, I removed this file in r40206. All tests in make test continue to pass. Closing ticket.

Thank you very much.
kid51

  Changed 5 years ago by coke

Thanks for applying this - can you also remove the notice from DEPRECATED.pod ?

  Changed 5 years ago by cotto

The deprecation notice was removed in r40433.

Note: See TracTickets for help on using tickets.