Ticket #1085 (closed patch: invalid)

Opened 5 years ago

Last modified 3 years ago

TclLibrary.pir and tcl_lib.t update

Reported by: vkon Owned by:
Priority: normal Milestone:
Component: library Version: 1.6.0
Severity: medium Keywords: tcl
Cc: coke, jkeenan Language:
Patch status: rejected Platform:

Description

Hi,

I would like to propose an update for TclLibrary.pir and tcl_lib.t, which will make much better MainLoop implementation (even two implementations) and also tcl library functions dealing with variables.

More patches to follow, especially into the tcl_lib.t

Attachments

parrot-41587-tcltklib-diff.txt Download (9.7 KB) - added by vkon 5 years ago.
the patch itself
parrot-41587-tcltklib-new-diff.txt Download (18.0 KB) - added by vkon 5 years ago.

Change History

Changed 5 years ago by vkon

the patch itself

Changed 5 years ago by vkon

noticed a typo in

# variable nethods: getvar, setvar2, unsetvar2, etc.

nevermind, I'll correct it

Changed 5 years ago by vkon

Changed 5 years ago by vkon

the new updated patch parrot-41587-tcltklib-new-diff.txt should be used instead of old one.

Changed 5 years ago by dukeleto

Please fix these codingstd test failures:

not ok 2 - All Pod files have non-empty DESCRIPTION sections # TODO POD requirements in flux: TT #292
# 
# Found 297 files without DESCRIPTION sections.
t/codingstd/pod_description.t ..... ok   
t/codingstd/pod_syntax.t .......... 2/2 
#   Failed test 'Pod syntax correct'
#   at t/codingstd/pod_syntax.t line 45.
#          got: 'runtime/parrot/library/TclLibrary.pir'
#     expected: ''
# You should use podchecker to check the failed files.
# Looks like you failed 1 test of 2.
t/codingstd/pod_syntax.t .......... Dubious, test returned 1 (wstat 256, 0x100)
Failed 1/2 subtests 
t/codingstd/pod_todo.t ............ 2/2 
not ok 2 - No todo items found # TODO some todo remain
t/codingstd/pod_todo.t ............ ok   
t/codingstd/svn_id.t .............. ok   
t/codingstd/tabs.t ................ ok   
t/codingstd/test_file_coverage.t .. ok   
t/codingstd/trailing_space.t ...... 1/1 
#   Failed test 'no trailing whitespace'
#   at t/codingstd/trailing_space.t line 49.
# Trailing space or tab char found in the following files:
# /Users/leto/git/parrot/runtime/parrot/library/TclLibrary.pir 420, 421
# That's 1 failed files out of 1091 files total.
# Looks like you failed 1 test of 1.
t/codingstd/trailing_space.t ...... Dubious, test returned 1 (wstat 256, 0x100)
Failed 1/1 subtests 

Test Summary Report
-------------------
t/codingstd/pod_syntax.t        (Wstat: 256 Tests: 2 Failed: 1)
  Failed test:  2
  Non-zero exit status: 1
t/codingstd/trailing_space.t    (Wstat: 256 Tests: 1 Failed: 1)
  Failed test:  1
  Non-zero exit status: 1
Files=34, Tests=324, 139 wallclock secs ( 0.78 usr  0.46 sys + 112.01 cusr  7.93 csys = 121.18 CPU)
Result: FAIL
make[1]: *** [codetest] Error 1
make: [fulltest] Error 2 (ignored)

Changed 5 years ago by dukeleto

You can run the full test suite with 'make fulltest'

Changed 3 years ago by jkeenan

  • cc coke, jkeenan added
  • patch set to new

We haven't heard back from the OP in 21 months. Looking at  the more recent patch and comparing it with the current content of runtime/parrot/library/TclLibrary.pir, I doubt the patch would apply cleanly.

Perhaps we could get someone familiar with Tcl to take a look at this?

Thank you very much.

kid51

Changed 3 years ago by coke

  • status changed from new to closed
  • resolution set to invalid
  • patch changed from new to rejected

Verified, patch no longer applies cleanly.

vkon - I'm not sure what the consensus is at the moment on making more libraries available from inside parrot; but coding standards issues raised against the latest patch and the current un-applyable state of this patch means we have to reject.

Regards.

Note: See TracTickets for help on using tickets.