Ticket #109 (closed RFC: fixed)

Opened 6 years ago

Last modified 5 years ago

remove File::Spec

Reported by: particle Owned by:
Priority: normal Milestone: 1.0
Component: library Version:
Severity: medium Keywords:
Cc: Language:
Patch status: Platform:

Description (last modified by jkeenan) (diff)

Doesn't seem to be used or tested:

runtime/parrot/library/File/Spec.pir
runtime/parrot/library/File/Spec/Unix.pir
runtime/parrot/library/File/Spec/Win32.pir
16:28 <@particle> coke: put File/Spec.pir on the remove list
16:42 <@particle> nothing uses it. it's half-implemented on win32 and abandoned.
16:42 <@particle> (and not implemented on any other platforms)

Change History

  Changed 6 years ago by coke

  • component changed from none to library

  Changed 6 years ago by barney

+1 I think that the OS PMC replaces that.

in reply to: ↑ description   Changed 6 years ago by jkeenan

  • description modified (diff)

Replying to particle:

Doesn't seem to be used or tested: {{{ runtime/parrot/library/File/Spec.pir runtime/parrot/library/File/Spec/Unix.pir runtime/parrot/library/File/Spec/Win32.pir }}} {{{ 16:28 <@particle> coke: put File/Spec.pir on the remove list 16:42 <@particle> nothing uses it. it's half-implemented on win32 and abandoned. 16:42 <@particle> (and not implemented on any other platforms) }}}

  Changed 6 years ago by jkeenan

  • description modified (diff)

While I can't locate anything that uses this PIR, does not this file constitute a valid test of it?

t/library/File_Spec.t

It runs as part of every make test:

t/library/File_Spec.........................ok

  Changed 6 years ago by coke

  • milestone set to 1.0

Fair enough. But if the only place the code is run is in the test suite, then it's still unused and removable. I've added it to DEPRECATED.pod and marked the milestone here appropriately.

  Changed 5 years ago by coke

  • status changed from new to closed
  • resolution set to fixed

Removed in r36860.

Note: See TracTickets for help on using tickets.