Ticket #1095 (closed cage: fixed)

Opened 5 years ago

Last modified 5 years ago

[PATCH] un-TODO unconditionally some tests in t/op/io.t

Reported by: geraud Owned by:
Priority: normal Milestone:
Component: testing Version: 1.6.0
Severity: medium Keywords:
Cc: Language:
Patch status: applied Platform:

Description

There are 2 tests in t/op/io.t which have a TODO status that seems to depend on the OS used. Currently known passing systems are Win32, Linux, Mac OS X and Open BSD. For quite some time now my FreeBSD boxes have reported succes for these two tests as well.

I first raised this issue (initially in order to add FreeBSD as a passing system) on IRC in August (see  http://irclog.perlgeek.de/parrot/2009-08-13#i_1389952 ) but NotFound++ suggested to just remove the test because the number of passing OSes was just including everything and was not relevant anymore.

I attached the patch I nopaste'd in August.

Attachments

patch-t_op_io.t Download (1.4 KB) - added by geraud 5 years ago.
patch2_t_io.t Download (1.0 KB) - added by geraud 5 years ago.

Change History

Changed 5 years ago by geraud

in reply to: ↑ description   Changed 5 years ago by darbelo

  • status changed from new to closed
  • resolution set to fixed
  • patch set to applied

Patch applied in r41731. Closing ticket as "fixed".

  Changed 5 years ago by coke

  • status changed from closed to reopened
  • resolution fixed deleted

New patch just applied for reconsideration.

  Changed 5 years ago by geraud

As per Coke's suggestion, I'm submitting a patch inverting the logic of the platforms on which the tests should be todo'ed.

Now 'tt661_todo_test' returns 1 if the test must be todo'ed and 0 otherwise. Only platforms known to fail are listed in the body of the sub.

And finally, invert the test logic in the 'open_pipe_for_writing' sub.

Tested locally on FreeBSD.

Changed 5 years ago by geraud

  Changed 5 years ago by darbelo

Patch applied in r42537. Closing ticket.

  Changed 5 years ago by darbelo

  • status changed from reopened to closed
  • resolution set to fixed
Note: See TracTickets for help on using tickets.