Changes between Initial Version and Version 33 of Ticket #1105

Show
Ignore:
Timestamp:
11/06/09 19:41:38 (12 years ago)
Author:
darbelo
Comment:

Replying to plobsing:

and that patch won't work either :-S. attaching a slightly hand-modified, tested patch. It doesn't apply cleanly, but it does pass tests. I can't figure out how to tell diff/patch that I really do want to delete files so, for the following files, 1) no this isn't a reversed patch 2) these files also *should* be deleted: * src/frame_builder.c * config/auto/frames/* Also don't worry about src/frame_builder.h not applying cleanly. It applies clean enough.

Legend:

Unmodified
Added
Removed
Modified

  • Ticket #1105

    • Property status changed from new to assigned
    • Property cc jkeenan, whiteknight, bacek added
    • Property patch changed from to applied
    • Property version changed from trunk to branch
    • Property owner set to jkeenan
    • Property summary changed from [PATCH] change to a libjit based frame builder to change to a libjit based frame builder

  • Ticket #1105 – description

    initial v33  
    1 This patch removes the old i386 frame builder and replaces it with one based on libjit. 
     1Latest patch applied to the new libjit_framebuilder branch, passes all tests on OpenBSD i386 without libjit installed. 
     2I don't have easy to install libjit packages for my platform, so all I'm able to check right now is that it introduces no regressions. 
    23 
    3 Changes: 
    4  
    5 remove all but the public API from public files: 
    6  
    7 src/frame_builder.h 
    8 src/frame_builder.c 
    9  
    10 make jit_buffer_private_data truly private: 
    11  
    12 tools/build/nativecall.pl 
    13  
    14 add test of dynamic frame builder: 
    15  
    16 src/nci_test.c 
    17 t/pmc/nci.t 
    18  
    19 detect presence of libjit: 
    20  
    21 config/auto/libjit.pm 
    22 config/auto/libjit 
    23 config/auto/libjit/libjit_c.in 
    24 t/steps/auto/libjit-01.t 
    25  
    26 generate source files: 
    27  
    28 config/gen/libjit 
    29 config/gen/libjit/frame_builder_libjit_c.in 
    30 config/gen/libjit/frame_builder_libjit_h.in 
    31 t/steps/gen/libjit-01.t 
    32  
    33 add new steps, as well as '--without-libjit' option, to Configure.pl: 
    34  
    35 lib/Parrot/Configure/Options/Conf.pm 
    36 lib/Parrot/Configure/Options/Conf/Shared.pm 
    37 lib/Parrot/Configure/Step/List.pm 
    38  
    39 add new source files to build: 
    40  
    41 config/gen/makefiles/root.in 
     4Somebody on a libjit-enabled platform should test (and benchmark) the branch as well before we merge back into trunk. But the code looks good overall and I consider this a step in the right direction.