Ticket #1118 (closed RFC: wontfix)

Opened 5 years ago

Last modified 4 years ago

[PATCH] Added __END__ to pir

Reported by: mgrimes Owned by: allison
Priority: minor Milestone:
Component: imcc Version:
Severity: low Keywords:
Cc: Language:
Patch status: new Platform: all

Description

The attached patch adds END to pir. Similar to Perl5, it is treated it as if we hit EOF.

The file "addEND.patch" includes changes to imcc.l and a new test file. If parrot is configured with --maintainer, then running make will generate the updated "imclexer.c". I have included generated imclexer.c as a separate patch.

Thanks, Mark

Attachments

add__END__.patch Download (1.3 KB) - added by mgrimes 5 years ago.
add__END__-imclexer.c.patch Download (243.0 KB) - added by mgrimes 5 years ago.

Change History

Changed 5 years ago by mgrimes

Changed 5 years ago by mgrimes

  Changed 5 years ago by coke

  • owner set to allison
  • version 1.6.0 deleted
  • type changed from feature to RFC

Assigning to allison for feature review.

  Changed 5 years ago by dukeleto

Are we going forward with this patch? Do we want this feature? Does it have performance issue? What is the deal?

  Changed 5 years ago by coke

-1 from me.

  Changed 5 years ago by mgrimes

I found this feature very useful in migrating tests from Perl to PIR. I have also used it frequently in Perl 5.

I'm not aware of any performance issues. There was little new code required to implement it, none of which would seem to have an impact on performance, but I haven't profiled it.

follow-up: ↓ 6   Changed 5 years ago by dukeleto

Coke, care to expand on your -1 ? Is it just that you don't want to change IMCC, or you don't want PIR to have this feature?

in reply to: ↑ 5   Changed 5 years ago by coke

Replying to dukeleto:

Coke, care to expand on your -1 ? Is it just that you don't want to change IMCC, or you don't want PIR to have this feature?

Don't feel we need this in PIR.

  Changed 5 years ago by coke

See  http://lists.parrot.org/pipermail/parrot-dev/2009-December/003439.html for some further discussion. I don't think we have a workable proposal yet.

  Changed 4 years ago by allison

a) A magical keyword that truncates the rest of the file isn't particularly useful. (You can use a pod block as a comment if needed, but generally "deactivated" code floating around is a maintenance headache.) b) The BLAH syntax is a terrible fit for PIR, it's just not like anything else.

  Changed 4 years ago by coke

  • status changed from new to closed
  • resolution set to wontfix

Based on allison's comment six weeks ago and previous discussion on thread, rejecting this RFC.

Note: See TracTickets for help on using tickets.