Ticket #113 (closed bug: fixed)

Opened 6 years ago

Last modified 4 years ago

[PATCH] sal.h is not included in Visual Studio.NET 2003

Reported by: bjoern Owned by: rblasch
Priority: normal Milestone:
Component: configure Version:
Severity: medium Keywords:
Cc: whiteknight, fperrad, rblasch Language:
Patch status: applied Platform: win32

Description

parrot/compiler.h has a _MSC_VER check to conditionally include the sal.h header file. As the comment suggests it is available with the 2008 version, but apparently not with the 2003 version. The version check however tests for 2003 or later, the patch should change that to 2008 or later.

Attachments

sal-h-check.patch Download (0.7 KB) - added by bjoern 6 years ago.
patch
probe-MS-header-sal.patch Download (3.3 KB) - added by fperrad 5 years ago.

Change History

Changed 6 years ago by bjoern

patch

Changed 6 years ago by rblasch

  • status changed from new to assigned
  • owner set to rblasch
  • platform set to win32
  • patch changed from new to applied

_MSC_VER > 1500 is not quite appropriate, as the latest version (Visual C++ 2008 aka Visual C++ 9) has version 1500. It's more like _MSC_VER >= 1400 , because it was introduced with Visual C++ 8.

Maybe Configure should even probe for sal.h .

Changed 5 years ago by jkeenan

  • component changed from none to configure

Changed 5 years ago by fperrad

Changed 5 years ago by fperrad

  • cc whiteknight added

I write a patch which probes sal.h

It could help for Win64.

Need test.

Changed 5 years ago by fperrad

probe-MS-header-sal.patch applied in r41298

Changed 4 years ago by jkeenan

  • cc fperrad, rblasch added

Ron and other contributors:

François applied his patch 12 months ago and we haven't had any complaints since.

Is there any reason to keep this ticket open?

If there is, please indicate what problems remain. If not, I will close it within 7 days.

Thank you very much.

kid51

Changed 4 years ago by rblasch

  • status changed from assigned to closed
  • resolution set to fixed

Seems to work for me, with latest trunk (r48820) and VC++ 7.1 (version without SAL). Newer VC++ versions are still good, of course. I'm closing this ticket. Thanks for the nudge, James.

Note: See TracTickets for help on using tickets.