Ticket #1130 (closed bug: fixed)
dependency problem for libnci_test
|Reported by:||doughera||Owned by:||jkeenan|
Revision r41942 added $(ALL_PARROT_LIBS) to the ld line for libnci_test. There are three problems with this:
1. The LIBNCI_TEST target doesn't have a dependency on libparrot, so make can try to build LIBNCI_TEST before libparrot is available.
2. The LIBNCI_TEST target is not built with appropriate rpath incantations (i.e. rpath_blib) so the test suite might not be able to find the shared libparrot. This would show up as failures in the t/pmc/nci.t tests. (To fix it to include rpath correctly would require building two versions of libnci_test.so -- one for use in the build directory (with rpath_blib), and one for installation (built with rpath_lib).
3. All those gyrations seem unnecessary. Does libnci_test.so really need to link with -lparrot? It didn't in parrot-1.6.0. The svn log comment mentions that this was a problem on Win32, but I don't know why it wasn't a problem earlier. Not knowing much about Win32 dynamic linking, and not knowing anything about the specific problem, I am hesitant to speculate.