Ticket #1140 (closed bug: fixed)

Opened 5 years ago

Last modified 4 years ago

config/gen/platform/generic/env.c unsetenv() out of sync

Reported by: doughera Owned by: jkeenan
Priority: normal Milestone:
Component: configure Version: 1.7.0
Severity: medium Keywords:
Cc: Language:
Patch status: new Platform:

Description

Revision r41961 fixed an unsetenv() bug on Windows (see TT #1093) but it turns out the exact same error is also present in the "generic" version of this file in config/gen/platform/generic/env.c.

I started to work up a patch to make the parallel change to the generic file, but then I realized that those two files are almost identical in effect, but have drifted apart. Is there a good reason for this code duplication, or should both files be combined, perhaps with a few judicious Win32 #ifdef statements. Would a patch to re-combine the two be welcome, or is the preference to keep them separate?

Along a similar vein, I wonder how many of the differences between the platform/openbsd/ and platform/netbsd/ files are truly significant. Carrying the current arrangement further, I wonder why there's no freebsd or dragonflybsd directory. I seek to avoid pointless duplication.

Attachments

tt1140-minimalist-fix.patch Download (0.6 KB) - added by doughera 4 years ago.
A minimalist fix for generic/env.c

Change History

Changed 4 years ago by doughera

A minimalist fix for generic/env.c

Changed 4 years ago by doughera

  • patch set to new

Changed 4 years ago by gerd

The patch is looking okay for me. Applied at r48054. Thanks.

Changed 4 years ago by jkeenan

  • status changed from new to assigned
  • owner set to jkeenan

Changed 4 years ago by jkeenan

  • status changed from assigned to closed
  • resolution set to fixed

I have taken this ticket for the purpose of closing it. It appears that Andy's patch has been working okay for five months.

Andy, if there are larger issues which you think need to be addressed, please open a new ticket.

Thank you very much.

kid51

Note: See TracTickets for help on using tickets.