Ticket #119 (closed patch: done)

Opened 6 years ago

Last modified 6 years ago

[PATCH] refactor configure steps for libraries

Reported by: fperrad Owned by:
Priority: normal Milestone:
Component: configure Version:
Severity: medium Keywords:
Cc: Language:
Patch status: Platform: all

Description (last modified by jkeenan) (diff)

Many libraries are only used by PMC or via NCI. So, don't put them in @libs@, we don't need them to link parrot executable & shared lib.

Feedback on any platform are welcome.

In readline.pm, the second chance with ncurses looks strange. Which platform needs this ?

François Perrad.

Attachments

conf-libs.patch Download (45.1 KB) - added by fperrad 6 years ago.
make.test.failures.Darwin.ppc.txt Download (1.8 KB) - added by jkeenan 6 years ago.
3 new test failures once fperrad's patch is applied (Darwin, but not Linux)
conf-libs-r34981.patch Download (44.0 KB) - added by fperrad 6 years ago.
update patch against r34981 (solve conflict in opengl.pm)

Change History

Changed 6 years ago by fperrad

Changed 6 years ago by jkeenan

3 new test failures once fperrad's patch is applied (Darwin, but not Linux)

in reply to: ↑ description ; follow-up: ↓ 2   Changed 6 years ago by jkeenan

  • description modified (diff)

Replying to fperrad:

Many libraries are only used by PMC or via NCI. So, don't put them in @libs@, we don't need them to link parrot executable & shared lib. Feedback on any platform are welcome.

François,

I appreciate your taking a look at these files. I *especially* appreciate the work that you put into to modifying the configuration step tests as needed to make this patch work!

I applied this patch on both Darwin and Linux. All pre- and post-configuration tests continue to pass.

All tests in 'make test' continued to pass on Linux. However, on Darwin/PPC I got three new failures ('new' in the sense that I did not get them in trunk about 9 hours ago). See attachment.

Thanks.
kid51

Changed 6 years ago by fperrad

update patch against r34981 (solve conflict in opengl.pm)

in reply to: ↑ 1   Changed 6 years ago by fperrad

Replying to jkeenan:

Replying to fperrad:

Many libraries are only used by PMC or via NCI. So, don't put them in @libs@, we don't need them to link parrot executable & shared lib. Feedback on any platform are welcome.

François, I appreciate your taking a look at these files. I *especially* appreciate the work that you put into to modifying the configuration step tests as needed to make this patch work! I applied this patch on both Darwin and Linux. All pre- and post-configuration tests continue to pass. All tests in 'make test' continued to pass on Linux. However, on Darwin/PPC I got three new failures ('new' in the sense that I did not get them in trunk about 9 hours ago). See attachment.

It isn't the kind of problem that I expected.

But could you send me some gdb backtrace of these segfaults (SIGNAL 10) on Darwin/PPC.

François.

Thanks.
kid51

  Changed 6 years ago by fperrad

  • status changed from new to closed
  • resolution set to done

Applied in r35899.

François

Note: See TracTickets for help on using tickets.