Ticket #1191 (closed deprecation: done)

Opened 5 years ago

Last modified 4 years ago

Deprecate Parrot_get_runtime_prefix

Reported by: NotFound Owned by: NotFound
Priority: trivial Milestone:
Component: core Version: 1.7.0
Severity: low Keywords:
Cc: Language:
Patch status: Platform:

Description

The function Parrot_get_runtime_prefix returns a char *, which is inconvenient because all usages want a parrot string. The function Parrot_get_runtime_path was introduced to get rid of that, and a note about his deprecation added to src/library.c

However someone (probably me) forgot to add a note to DEPRECATED.pod

This is the last chance if someone wants to keep that function.

This issue was discused in RT #58988, and also was a discussion about the function name.

Change History

Changed 5 years ago by coke

  • cc notfound added

There is still no note in DEPRECATED.pod.

Changed 5 years ago by jkeenan

  • owner set to NotFound
  • cc notfound removed

NotFound,

Since this function still has not been deprecated, could you follow up if that is still appropriate?

Thank you very much.

kid51

For reference:

fns . | xargs grep -l Parrot_get_runtime_prefix
./src/library.c
./docs/embed.pod
./lib/Parrot/Test.pm
./include/parrot/library.h

Changed 5 years ago by mikehh

just for fun I did an ack on it ->

mhb@mhb-desktop:~/parrot$ ack Parrot_get_runtime_prefix
include/parrot/library.h
51:char* Parrot_get_runtime_prefix(PARROT_INTERP)
107:#define ASSERT_ARGS_Parrot_get_runtime_prefix __attribute__unused__ int _ASSERT_ARGS_CHECK = (\

src/library.c
791:=item C<char* Parrot_get_runtime_prefix(PARROT_INTERP)>
807:Parrot_get_runtime_prefix(PARROT_INTERP)
809:    ASSERT_ARGS(Parrot_get_runtime_prefix)
812:    Parrot_warn_deprecated(interp, "Parrot_get_runtime_prefix is deprecated TT #1191");

lib/Parrot/Test.pm
300:# (see Parrot_get_runtime_prefix in src/library.c).

docs/embed.pod
790:=item C<Parrot_get_runtime_prefix>

docs/html/docs/embed.pod.html
852:<dt><a name="Parrot_get_runtime_prefix"
853:><b><code>Parrot_get_runtime_prefix</b></code></a></dt>
mhb@mhb-desktop:~/parrot$

Changed 5 years ago by NotFound

Urgh, I forgot to add the deprecation notice again.

Done now in r47598

Changed 5 years ago by jkeenan

  • component changed from none to core

Changed 4 years ago by NotFound

  • status changed from new to closed
  • resolution set to done
  • type changed from cage to deprecation

Removed in 48947, closing ticket.

Note: See TracTickets for help on using tickets.