Ticket #120 (closed RFC: fixed)

Opened 6 years ago

Last modified 5 years ago

Deprecated: DWIM.pir

Reported by: coke Owned by: jkeenan
Priority: normal Milestone:
Component: library Version:
Severity: medium Keywords:
Cc: Language:
Patch status: applied Platform:

Description

This library file, while cute, isn't compiling anymore, and doesn't need to be in our core library for 1.0.

Let's just remove it, and the (failing) example that uses it.

Attachments

DWIM.pir.patch Download (10.7 KB) - added by jkeenan 5 years ago.
Deprecation of DWIM.pir: patch for re-application

Change History

  Changed 6 years ago by jkeenan

  • status changed from new to assigned
  • owner set to jkeenan

  Changed 6 years ago by jkeenan

  • status changed from assigned to closed
  • resolution set to fixed

Done in  r34951.

follow-ups: ↓ 4 ↓ 5 ↓ 8   Changed 6 years ago by coke

  • status changed from closed to reopened
  • resolution fixed deleted

Thanks for the prompt action on this ticket, but I had opened it as an RFC to elicit comment. (I took a more authoritative tone in the original description to give folks a target to shoot at.)

Since DWIM.pir is in our standard library, we should put it through a deprecation cycle first if we are going to remove it. (And so far, it's just the two of us that think it should be.)

If you could revert r34951, we can very likely re-apply it after the 0.9.0 release.

Thanks.

in reply to: ↑ 3   Changed 6 years ago by jkeenan

Replying to coke:

If you could revert r34951, we can very likely re-apply it after the 0.9.0 release.

Okay, but I won't be able to get to this until tonight or tomorrow.

kid51

in reply to: ↑ 3   Changed 6 years ago by jkeenan

Replying to coke:

If you could revert r34951, we can very likely re-apply it after the 0.9.0 release.

Reverted in  r35012.

kid51

  Changed 6 years ago by coke

  • component changed from none to library

  Changed 6 years ago by coke

  • summary changed from remove DWIM.pir to Deprecated: DWIM.pir

in reply to: ↑ 3   Changed 6 years ago by jkeenan

Replying to coke:

If you could revert r34951, we can very likely re-apply it after the 0.9.0 release.

Coke: Shall I proceed to reapply r34951?

  Changed 6 years ago by coke

Sure.

Changed 5 years ago by jkeenan

Deprecation of DWIM.pir: patch for re-application

  Changed 5 years ago by jkeenan

Am attaching what was originally applied in r34951 so that it can be double-checked before I apply it.

kid51

  Changed 5 years ago by jkeenan

  • status changed from reopened to closed
  • resolution set to fixed
  • patch set to applied

Patch re-applied in  r36074. Closing ticket.

Note: See TracTickets for help on using tickets.