Ticket #1218 (closed bug: fixed)

Opened 5 years ago

Last modified 5 years ago

[PATCH] t/dynpmc/foo2.t converted to PIR

Reported by: bubaflub Owned by: Util
Priority: trivial Milestone:
Component: testing Version: 1.7.0
Severity: low Keywords:
Cc: Language:
Patch status: Platform:

Description

Attached is a patch to convert the test t/dynpmc/foo2.t to PIR. Only one test in this one, pretty simple stuff. I wonder if it should be combined with foo.t.

Attachments

dynpmc_foo2.patch Download (1.2 KB) - added by bubaflub 5 years ago.
patch for t/dynpmc/foo2.t

Change History

Changed 5 years ago by bubaflub

patch for t/dynpmc/foo2.t

Changed 5 years ago by Util

  • owner set to Util

Changed 5 years ago by Util

  • status changed from new to assigned

Changed 5 years ago by Util

  • status changed from assigned to closed
  • resolution set to fixed

Regarding combining the .t files:

Since foo.pmc is separate from foo2.pmc, but they are compiled together into a single foo_group library, it would make sense to combine the .t files. Logically, the resulting .t file would be named foo_group.t, not foo.t.

However, since I expect foo.t to be split into multiple tests (see TT #1217), we should not merge foo2.t (unless foo.t is decided to remain intact).

Regarding the patch itself:

The code changes looks great! Also, you were correct to change the copyright date from its erroneous 2005 value, but since the file was written in 2009, the range 2001-2009 is not appropriate. With that one correction, patch applied in r42950.

Note: See TracTickets for help on using tickets.