Ticket #1227 (closed bug: fixed)
[PATCH] config/gen/crypto/digest_t.in for generated tests in t/dynpmc
| Reported by: | bubaflub | Owned by: | |
|---|---|---|---|
| Priority: | trivial | Milestone: | |
| Component: | testing | Version: | 1.7.0 |
| Severity: | low | Keywords: | |
| Cc: | Language: | ||
| Patch status: | applied | Platform: |
Description
Attached are two patches. The first converts config/gen/crypto/digest_t.in to PIR. This template is used for the following generated tests:
t/dynpmc/md2.t t/dynpmc/md4.t t/dynpmc/md5.t t/dynpmc/ripemd160.t t/dynpmc/sha.t t/dynpmc/sha1.t t/dynpmc/sha256.t t/dynpmc/sha512.t
The second patches config/gen/crypto.pm. Where I could find it, the tests will now test an exact hash value rather than just verify the length of the hex output. Where I couldn't find it I updated the regex to actually function with parrot.
The only problem with these patches is now config/gen/crypto/digest_t.in fails the t/codingstd/pir_code_coda.t . The failure comes from digest_t.in line 46-47 where the template symbol @TEMP_md_name@ is used. Perhaps either pir_code_coda.t should be patched to ignore this file or digest_t.in should have the "# THIS IS A GENERATED FILE! DO NOT EDIT!" warning added to the top.
Attachments
-
config_gen_crypto_digest_t.patch
(2.5 KB) - added by bubaflub
5 years ago.
- patch for config/gen/crypto/digest_t.in
-
config_gen_crypto.patch
(1.7 KB) - added by bubaflub
5 years ago.
- patch for config/gen/crypto.pm
