Ticket #1234 (closed cage: fixed)

Opened 5 years ago

Last modified 5 years ago

t/op/hacks.t: Delete useless test file

Reported by: jkeenan Owned by: jkeenan
Priority: minor Milestone:
Component: testing Version: 1.7.0
Severity: low Keywords:
Cc: Language:
Patch status: Platform:

Description

In the course of working on TT #1189, I have had occasion to search for files, in the configuration system or elsewhere, which depend unnecessarily on the Perl 5 %Config found on the system where Parrot is being built. I will be opening additional tickets for cases where I find such dependencies in files outside the configuration step tests.

t/op/hacks.t was created by Dan in December 2001. Its initial commit bears this log message:

THESE OPS ARE EVIL! AND TEMPORARY! USE FOR DEBUGGING PURPOSES ONLY!

Not surprisingly, this test file is objectionable on a number of levels:

1. Its DESCRIPTION says it "Tests basic file IO operations," but it does nothing of the sort.

2. It has an internal subroutine, has_signal(), which does a look-up on the Perl 5 %Config:

sub has_signal {
    my $sig = shift;
    foreach my $name ( split( ' ', $Config{sig_name} ) ) {
        return 1 if ( "SIG$name" eq $sig );
    }
    return 0;
}

(It imports Parrot::Config but does nothing with it.)

3. All (actually, both) its tests are SKIPped:

SKIP: {
    skip( "no universal SIGFPE handling", 2 );
    ...

AFAICT, the SKIP was introduced in July 2003. (I can't tell for sure, because this is one of those files that was mangled in the conversion from CVS to SVN; svn blame claims it's a binary file.)

So it has contributed nothing to our understanding of Parrot's strengths and weaknesses in six years!

Time to toss it. I will do so in 3-4 days unless there is serious objection.

Thank you very much.

kid51

Change History

Changed 5 years ago by jkeenan

  • owner set to jkeenan
  • status changed from new to assigned

Changed 5 years ago by jkeenan

  • status changed from assigned to closed
  • resolution set to fixed

File deleted in r42408. Closing ticket.

Note: See TracTickets for help on using tickets.