Parrot won't build on windows due to new assert stuff

[kjs]

The recent updates with parrot assert stuff prevents parrot from building on windows: (Revision: r34868)

"Compiling with:" xx.c cl -I.\include -nologo -GF -W4 -MD -Zi -DNDEBUG -DWIN32 -D_CONSOLE -DNO_STRICT -DNO_HASH_SEED -DUSE_SITECUSTOMIZE -DPRIV LIB_LAST_IN_INC -D_CRT_SECURE_NO_DEPRECATE -DHASATTRIBUTE_DEPRECATED -wd4101 -DHASATTRIBUTE_NORETURN -wd4101 -Zi -wd4127

-wd4054 -wd4310 -DHAS_JIT -DI386 -I. -Fo xx.obj -c xx.c

src\string.c G:\cygwin\home\Kramer\parrot1\include\parrot/exceptions.h(283) : warning C4431: missing type specifier - int assumed. No te: C no longer supports default-int G:\cygwin\home\Kramer\parrot1\include\parrot/exceptions.h(283) : error C2054: expected '(' to follow 'inline' G:\cygwin\home\Kramer\parrot1\include\parrot/exceptions.h(285) : error C2085: '_PARROT_ASSERT_ARG' : not in formal param eter list G:\cygwin\home\Kramer\parrot1\include\parrot/exceptions.h(285) : error C2143: syntax error : missing ';' before '{' src\string.c(85) : warning C4013: '_PARROT_ASSERT_ARG' undefined; assuming extern returning int NMAKE : fatal error U1077: 'G:\Perl\bin\perl.exe' : return code '0x2' Stop.

kjs

[jkeenan]

'make' log showing failure on Darwin/ppc after assert_args branch merged into trunk

[jkeenan]

The updates built fine for me on Linux, but broke 'make' on Darwin. See build log attached.

[Infinoid]

Ok, I wasn't aware "inline" wasn't C89. Here's a patch that converts the system to use only macros. I know it works on gcc, I am hoping it fixes things on msvc.

[Infinoid]

Replying to jkeenan:

The updates built fine for me on Linux, but broke 'make' on Darwin. See build log attached.

Thanks, looks like you have a different issue from kjs's MSVC issue.

It looks like the issue on darwin/ppc is that "make headerizer" hasn't been run recently on the ppc platform. Sorry, I should have realized that I can't test those files. I've backed out the ASSERT_ARGS changes for ppc and arm for now in r34890. This should get builds working again, though it may cause a failure in t/codingstd/c_arg_assert.t. Once headerizer has generated the assert macros, those changes can be reverted and life should be good.

[Infinoid]

updated patch with an extra set of parens, to solve an operator precedence issue (it built fine, but wasn't catching failures properly).

[jkeenan]

Replying to Infinoid:

Replying to jkeenan:

Infinoid did some fixing which enabled me to once again complete 'make' on Darwin/PPC as of r34890':  http://smolder.plusthree.com/app/public_projects/report_details/11779

[Infinoid]

Replying to Infinoid:

Ok, I wasn't aware "inline" wasn't C89. Here's a patch that converts the system to use only macros. I know it works on gcc, I am hoping it fixes things on msvc.

I applied that change earlier today as r34896. It significantly simplifies (and in my mind, improves) the API, and I also think it has a good chance of fixing the build issue on MSVC; please try it and let me know either way.

[kjs]

The issue has been resolved.