Ticket #1257 (closed todo: fixed)

Opened 12 years ago

Last modified 11 years ago

src/io/utf8.c: Does the amount read in Parrot_io_read_utf8() need to be checked?

Reported by: jkeenan Owned by: jkeenan
Priority: normal Milestone:
Component: core Version: 1.7.0
Severity: medium Keywords:
Cc: allison Language:
Patch status: Platform:


This ticket moves into Trac discussion of an issue originally tracked in RT at  RT #46413.

In that RT, Paul Cochrane cited lines in the file now known as src/io/utf8.c:

 46 size_t
 47 Parrot_io_read_utf8(PARROT_INTERP, ARGMOD(PMC *filehandle),
 48         ARGMOD(STRING **buf))
 49 {
 83                 /* RT#46413 need to check the amount read here? */
 84                 read         = Parrot_io_read_buffer(interp, filehandle, &s2    );          
 85                 UNUSED(read);

Paul commented, "At present this variable is marked UNUSED(read). However, it might be a good idea to actually check the amount read in this function call. After which the UNUSED() needs to disappear."

Can someone follow up?

Change History

Changed 11 years ago by jkeenan

  • status changed from new to assigned
  • owner set to jkeenan

Reviewing this old ticket today leads me to ask, "Can anyone suggest what we might do with the amount read here?"

If not, I will remove the TODO item and close this ticket within 7 days.

Thank you very much.


Changed 11 years ago by jkeenan

  • status changed from assigned to closed
  • resolution set to fixed

No one spoke up to suggest "something we might do with the amount read" there, so I eliminated the comment in r48777. Closing ticket.

Thank you very much.


Note: See TracTickets for help on using tickets.