Ticket #1257 (closed todo: fixed)
src/io/utf8.c: Does the amount read in Parrot_io_read_utf8() need to be checked?
Reported by: | jkeenan | Owned by: | jkeenan |
---|---|---|---|
Priority: | normal | Milestone: | |
Component: | core | Version: | 1.7.0 |
Severity: | medium | Keywords: | |
Cc: | allison | Language: | |
Patch status: | Platform: |
Description
This ticket moves into Trac discussion of an issue originally tracked in RT at RT #46413.
In that RT, Paul Cochrane cited lines in the file now known as src/io/utf8.c:
46 size_t 47 Parrot_io_read_utf8(PARROT_INTERP, ARGMOD(PMC *filehandle), 48 ARGMOD(STRING **buf)) 49 { ... 83 /* RT#46413 need to check the amount read here? */ 84 read = Parrot_io_read_buffer(interp, filehandle, &s2 ); 85 UNUSED(read);
Paul commented, "At present this variable is marked UNUSED(read). However, it might be a good idea to actually check the amount read in this function call. After which the UNUSED() needs to disappear."
Can someone follow up?
Change History
Note: See
TracTickets for help on using
tickets.