Ticket #1315 (closed todo: fixed)

Opened 5 years ago

Last modified 4 years ago

src/pmc/eval.pmc: create PF API, move it there

Reported by: jkeenan Owned by: jkeenan
Priority: normal Milestone:
Component: core Version: 1.8.0
Severity: medium Keywords:
Cc: jonathan, bacek, NotFound Language:
Patch status: Platform:

Description

I believe  RT #46685 was closed prematurely, so I'm moving it to Trac.

See this part of src/pmc/eval.pmc:

194         /* RT #46685 create PF API, move it there */
195         seg = (PackFile_Segment *)cur_cs->const_table;
196         if (seg) {
197             PackFile_Segment_destroy(INTERP, seg);
198             cur_cs->const_table = NULL;
199         }

(Am changing the RT reference to TT.)

Jonathan and Bacek commented in the RT, so I'm hoping one of them will take this ticket.

Change History

Changed 4 years ago by jkeenan

  • cc jonathan, bacek, NotFound added; jonathan bacek removed

Reviewing this old ticket today ...

Can I assume that PF API means packfile API? Do we have such an API? Do we ever plan to have one?

Am cc-ing some people who have done work around packfiles.

Thank you very much.

kid51

Changed 4 years ago by jkeenan

  • owner set to jkeenan
  • status changed from new to assigned

In conversation on #parrot today, NotFound noted that the comment no longer has much meaning because we now have several Packfile APIs.

I deleted the comment in r48956 and am closing the ticket.

Changed 4 years ago by jkeenan

  • status changed from assigned to closed
  • resolution set to fixed
Note: See TracTickets for help on using tickets.