Ticket #1336 (closed cage: fixed)

Opened 5 years ago

Last modified 5 years ago

Convert t/pmc/bigint.t to PIR

Reported by: kurahaupo Owned by: mikehh
Priority: normal Milestone:
Component: testing Version: trunk
Severity: medium Keywords: PIR GMP
Cc: Language:
Patch status: new Platform: all

Description (last modified by mikehh) (diff)

Convert t/pmc/bigint.t to PIR

Attachments

bigint.t.patch Download (46.8 KB) - added by kurahaupo 5 years ago.

Change History

Changed 5 years ago by kurahaupo

  Changed 5 years ago by mikehh

  • status changed from new to closed
  • resolution set to fixed

applied slightly modified at r42813

  Changed 5 years ago by jkeenan

  • keywords GMP added
  • status changed from closed to reopened
  • resolution fixed deleted

mikehh, kurahaupo:

The Perl version of this test handled well the case where the user has an older version of GMP installed. This new PIR version does not. Running this file on Darwin/PPC with GMP 4.1.3, I got this result:

t/pmc/bigint.t ..
1..45
This Parrot uses GMP
Buggy GMP version [4.1.3] with huge digit multiply - please upgrade
not ok 1
ok 2 #skip skipped
...
ok 45 #skip skipped
Dubious, test returned 1 (wstat 256, 0x100)
Failed 1/45 subtests
    (less 44 skipped subtests: 0 okay)

Test Summary Report
-------------------
t/pmc/bigint.t (Wstat: 256 Tests: 45 Failed: 1)
  Failed test:  1
  Non-zero exit status: 1
Files=1, Tests=45,  3 wallclock secs ( 0.09 usr  0.03 sys +  0.13 cusr  0.11 csys =  0.36 CPU)
Result: FAIL

Can you touch this up so that all tests are SKIP-ped? IIRC, that was this file's previous behavior on this platform.

Thank you very much.

kid51

  Changed 5 years ago by mikehh

  • status changed from reopened to new
  • owner set to mikehh
  • description modified (diff)

  Changed 5 years ago by mikehh

  • description modified (diff)

will see if I can resolve the issue (managed to change the description rather than comment last time)

  Changed 5 years ago by mikehh

  • status changed from new to assigned

follow-up: ↓ 7   Changed 5 years ago by mikehh

fix committed at r42888 - waiting for conformation before closing ticket.

in reply to: ↑ 6   Changed 5 years ago by jkeenan

Replying to mikehh:

fix committed at r42888 - waiting for confirmation before closing ticket.

It now DWIMs:

$ prove -v t/pmc/bigint.t
t/pmc/bigint.t .. 
1..45
This Parrot uses GMP
Buggy GMP version [4.1.3] with huge digit multiply - please upgrade
ok 1 #skip skipped
ok 2 #skip skipped
...
ok 44 #skip skipped
ok 45 #skip skipped
ok
All tests successful.
Files=1, Tests=45,  2 wallclock secs ( 0.12 usr  0.05 sys +  0.13 cusr  0.08 csys =  0.38 CPU)
Result: PASS

mikehh: Feel free to close ticket. Thanks for your quick attention to this.

kid51

  Changed 5 years ago by mikehh

  • status changed from assigned to closed
  • resolution set to fixed

It looks like the issue for re-opening the ticket is now resolved

Note: See TracTickets for help on using tickets.