Ticket #1337 (closed deprecation: fixed)

Opened 5 years ago

Last modified 3 years ago

deprecate runtime/parrot/library/Protoobject.pir

Reported by: pmichaud Owned by:
Priority: normal Milestone:
Component: none Version: 1.8.0
Severity: medium Keywords:
Cc: Language:
Patch status: Platform:

Description

I just noticed in #1312 that the tests for Protoobject.pir were converted to PIR.

I think that Protoobject.pir has been superceded by P6object.pir and can be deprecated. AFAIK none of the other PCT utilities make use of Protoobject.pir .

Pm

Change History

Changed 4 years ago by coke

  • type changed from bug to deprecation

Changed 4 years ago by NotFound

One test in t/compilers/pct/pct_hllcompiler.t still uses Protoobject, can someone take a look at it and convert it to P6object, or whatever appropiate?

Changed 3 years ago by Vasily Chekalkin

  • status changed from new to closed
  • resolution set to fixed

Remove deprecated Protoobject. Closes #1337.

Changeset: 0f269b944d5d10d85cfae2a0fb23027befd5b47c

Changed 3 years ago by NotFound

  • status changed from closed to reopened
  • resolution fixed deleted

Please fix this before closing the ticket:

$ prove -v t/compilers/pct/pct_hllcompiler.t t/compilers/pct/pct_hllcompiler.t .. 1..6 ok 1 - some of the auxiliary methods not ok 2 - one complete start-to-end compiler

# Failed test 'one complete start-to-end compiler' # at t/compilers/pct/pct_hllcompiler.t line 41. # Exited with error code: 1 # Received: # "load_bytecode" couldn't find file 'Protoobject.pbc' # current instr.: 'parrot;NoneGrammar;init' pc 93 (/home/julian/parrot/t/compilers/pct/pct_hllcompiler_2.pir:42) # # Expected: # thingy # ok 3 - default stages ok 4 - inserting and removing stages ok 5 - EXPORTALL method ok 6 - lineof method # Looks like you failed 1 test of 6. Dubious, test returned 1 (wstat 256, 0x100) Failed 1/6 subtests

Test Summary Report


t/compilers/pct/pct_hllcompiler.t (Wstat: 256 Tests: 6 Failed: 1)

Failed test: 2 Non-zero exit status: 1

Files=1, Tests=6, 0 wallclock secs ( 0.03 usr 0.00 sys + 0.11 cusr 0.05 csys = 0.19 CPU) Result: FAIL

Changed 3 years ago by bacek

  • status changed from reopened to closed
  • resolution set to fixed

Fixed in 4970e666f523b72a62c1f19fefb3bd50f00a1061

Note: See TracTickets for help on using tickets.