Ticket #1341 (closed patch: fixed)

Opened 5 years ago

Last modified 5 years ago

[PATCH] hide magic numbers in src/pmc_freeze.c with macros

Reported by: plobsing Owned by:
Priority: normal Milestone:
Component: none Version: 1.8.0
Severity: medium Keywords:
Cc: Language:
Patch status: Platform:

Description

src/pmc_freeze.c has the following comment:

/* TODO: get rid of these magic numbers; they look like pointer tags */

The attached patch hides the mentioned magic numbers using macros.

Note: I am not quite happy with the terms "PackID", "PMCID", and "FLAGS". I would appreciate suggestions to replace them.

Attachments

diff Download (4.3 KB) - added by plobsing 5 years ago.

Change History

Changed 5 years ago by plobsing

  • attachment diff Download added

Changed 5 years ago by cotto

  • status changed from new to closed
  • resolution set to fixed

Thanks. This was committed as r42832.

Note: See TracTickets for help on using tickets.