Ticket #1345 (closed patch: fixed)
[PATCH] eliminate {push,shift}_opcode_pmc from pmc_freeze
Reported by: | plobsing | Owned by: | |
---|---|---|---|
Priority: | normal | Milestone: | |
Component: | core | Version: | 1.8.0 |
Severity: | medium | Keywords: | |
Cc: | Language: | ||
Patch status: | Platform: |
Description
The pseudo-pmc used in pmc freeze/thaw includes operations that appear to mimic push/shift PMC.
Except: they don't push/shift a PMC to/from the image buffer. They push/shift a PMC ID, which is really just another integer as far as the image is concerned.
This is confusing and also leads to needless casting to/from PMC* of values that aren't really pointers.
The attached patch replaces all use of these operations with {push,shift}_integer.
Attachments
Change History
Note: See
TracTickets for help on using
tickets.