Ticket #1345 (closed patch: fixed)

Opened 5 years ago

Last modified 5 years ago

[PATCH] eliminate {push,shift}_opcode_pmc from pmc_freeze

Reported by: plobsing Owned by:
Priority: normal Milestone:
Component: core Version: 1.8.0
Severity: medium Keywords:
Cc: Language:
Patch status: Platform:

Description

The pseudo-pmc used in pmc freeze/thaw includes operations that appear to mimic push/shift PMC.

Except: they don't push/shift a PMC to/from the image buffer. They push/shift a PMC ID, which is really just another integer as far as the image is concerned.

This is confusing and also leads to needless casting to/from PMC* of values that aren't really pointers.

The attached patch replaces all use of these operations with {push,shift}_integer.

Attachments

pmc_freeze_push_shift.patch Download (6.1 KB) - added by plobsing 5 years ago.

Change History

Changed 5 years ago by plobsing

Changed 5 years ago by cotto

  • status changed from new to closed
  • resolution set to fixed

Thanks for adding a bit more sanity to this poor chunk of code. Your changes were applied as r42868.

Note: See TracTickets for help on using tickets.