Ticket #1347 (closed patch: fixed)

Opened 5 years ago

Last modified 5 years ago

[patch]removed unused codes in addrregistry.pmc

Reported by: jimmy Owned by:
Priority: normal Milestone:
Component: none Version: 1.8.0
Severity: medium Keywords:
Cc: Language:
Patch status: Platform:

Description

removed unused codes in addrregistry.pmc

I couldn't find where it is used or tested, so removed it.

Attachments

addrregistry_1.pmc.patch Download (0.7 KB) - added by jimmy 5 years ago.

Change History

Changed 5 years ago by jimmy

Index: src/pmc/addrregistry.pmc
===================================================================
--- src/pmc/addrregistry.pmc	(版本 42868)
+++ src/pmc/addrregistry.pmc	(工作副本)
@@ -40,18 +40,7 @@
 */
 
     VTABLE void init() {
-        Hash  *registry = parrot_create_hash(INTERP,
-                enum_type_int,
-                Hash_key_type_PMC,
-                int_compare,
-                key_hash_int);
-
-        Parrot_AddrRegistry_attributes *attrs =
-            (Parrot_AddrRegistry_attributes *) PMC_data(SELF);
-
-        SELF.set_pointer(registry);
         PObj_custom_mark_destroy_SETALL(SELF);
-
     }
 
 /*

Changed 5 years ago by jkeenan

See post in TT #1348.

Changed 5 years ago by jimmy

Changed 5 years ago by jimmy

re-added it. please review it again, thanks

JimmyZ

Changed 5 years ago by cotto

  • status changed from new to closed
  • resolution set to fixed

This PMC is intended for use primarily from C (the GC root set for instance), so it doesn't make sense to test it from PIR. I've commit your patch (except for the variable name change, where I believe that "registry" is more descriptive) as r42953. Thanks for contributing!

Note: See TracTickets for help on using tickets.