Ticket #1354 (closed patch: fixed)

Opened 5 years ago

Last modified 5 years ago

[patch]removed unused codes from Vtable.pm

Reported by: jimmy Owned by:
Priority: normal Milestone:
Component: core Version: 1.8.0
Severity: medium Keywords:
Cc: Language:
Patch status: new Platform:

Description

removed unused codes from Vtable.pm

Index: lib/Parrot/Vtable.pm
===================================================================
--- lib/Parrot/Vtable.pm	(版本 42868)
+++ lib/Parrot/Vtable.pm	(工作副本)
@@ -224,25 +224,12 @@
     (pmc)->vtable->$entry->[1]($args)
 EOM
     }
-    $macros .= <<'EOM';
-
+    # Slot numbers
+    $macros .= <<"EOM";
 /*
- * vtable method name defines for delegate
+ * vtable slot names
  */
-
 EOM
-    for my $entry ( @{$vtable} ) {
-        my $uc_meth = uc $entry->[1];
-        $macros .= <<"EOM";
-#define PARROT_VTABLE_${uc_meth}_METHNAME \"$entry->[1]\"
-EOM
-
-    }
-    $macros .= <<'EOM';
-
-EOM
-
-    # Slot numbers
     my $vtable_slot_num = 9;
     for my $entry ( @{$vtable} ) {
         my $uc_meth = uc $entry->[1];
@@ -254,9 +241,7 @@
 
     # finally the name mapping
     $macros .= <<'EOM';
-/*
- * vtable slot names
- */
+
 #ifdef PARROT_IN_OBJECTS_C
 
 #define PARROT_VTABLE_LOW 9

Attachments

Vtable.pm.patch Download (0.9 KB) - added by jimmy 5 years ago.

Change History

Changed 5 years ago by jimmy

  Changed 5 years ago by jkeenan

See post in TT #1348.

  Changed 5 years ago by jkeenan

  • component changed from none to core
  • patch set to new

follow-up: ↓ 4   Changed 5 years ago by jkeenan

This patch, considered by itself, passes make test on Linux/i386. See  this Smolder report.

It should be reviewed by someone more expert in vtables than me.

kid51

in reply to: ↑ 3   Changed 5 years ago by jimmy

Replying to jkeenan:

This patch, considered by itself, passes make test on Linux/i386. See  this Smolder report. It should be reviewed by someone more expert in vtables than me. kid51

hello, kid51. It just removed PARROT_VTABLE_*_METHNAME macros from vtable.h :)

Thank you for reviewing it.

JimmyZ

  Changed 5 years ago by cotto

  • status changed from new to closed
  • resolution set to fixed

Thanks for clearing out some cruft. This patch was committed as r42923.

Note: See TracTickets for help on using tickets.