Ticket #1372 (closed todo: fixed)

Opened 5 years ago

Last modified 4 years ago

Change usages of 'Getopt::Obj' to ['Getopt';'Obj']

Reported by: coke Owned by: jkeenan
Priority: normal Milestone:
Component: library Version: trunk
Severity: low Keywords:
Cc: Language:
Patch status: applied Platform:

Description

This should be reverted until post 2.0; while the new NS is the desired one, we've removed the original.

The best solution is probably to put it into /both/ namespace for 2.0, add the deprecation notice in 2.0, and then remove the old one post 2.0.

Attachments

tt1372.Getopt.Obj.pir.patch Download (1.8 KB) - added by jkeenan 4 years ago.
Adapted from tene's original patch in r43083

Change History

  Changed 5 years ago by dukeleto

Is this about JSON vs data_json ? The TT is ambiguous

  Changed 5 years ago by coke

  • summary changed from r43083 breaks support to changing 'Getopt::Obj' to ['Getopt';'Obj'] breaks API. (r43083)

This is for r43083, which changed 'Getopt::Obj' to ['Getopt';'Obj']

  Changed 5 years ago by coke

  • lang set to tcl
  • priority changed from normal to blocker
  • component changed from none to library
  • severity changed from medium to fatal

To be clear, this change completely breaks partcl (and any other language that is using this core library).

follow-up: ↓ 8   Changed 5 years ago by coke

  • summary changed from changing 'Getopt::Obj' to ['Getopt';'Obj'] breaks API. (r43083) to Change usages of 'Getopt::Obj' to ['Getopt';'Obj']

I believe a fix was committed for this that makes both variants available now; Let's add in a notice to DEPRECATED.pod about removing the old one as of version 2.1.

All the usages of the old version in core should be updated to the new version and tested.

  Changed 5 years ago by coke

  • lang tcl deleted

  Changed 5 years ago by coke

  • priority changed from blocker to normal
  • type changed from bug to todo
  • severity changed from fatal to low

  Changed 5 years ago by jkeenan

For reference, as of r43188 the only files in the repository that match for Getopt::Obj are:

./runtime/parrot/library/Getopt/Obj.pir
./t/library/getopt_obj.t

Changed 4 years ago by jkeenan

Adapted from tene's original patch in r43083

in reply to: ↑ 4   Changed 4 years ago by jkeenan

Replying to coke:

I believe a fix was committed for this that makes both variants available now; Let's add in a notice to DEPRECATED.pod about removing the old one as of version 2.1.

Coke,

Having passed the deprecation point, is the attached patch now applicable? (It passes make test; see  this Smolder report.)

Will it break partcl? Or, is avoiding breakage now the HLL's responsibility?

kid51

  Changed 4 years ago by jkeenan

  • patch set to new

follow-up: ↓ 11   Changed 4 years ago by coke

Yes, you can rip out the old version now that 2.0 is out. Thanks.

in reply to: ↑ 10   Changed 4 years ago by jkeenan

  • status changed from new to assigned
  • owner set to jkeenan
  • patch changed from new to applied

Replying to coke:

Yes, you can rip out the old version now that 2.0 is out. Thanks.

Applied in r43581. Will keep ticket open for 1-3 days for any complaints.

Thank you very much.
kid51

  Changed 4 years ago by jkeenan

  • status changed from assigned to closed
  • resolution set to fixed

No complaints recorded. Closing ticket.

Note: See TracTickets for help on using tickets.