Ticket #1397 (closed patch: invalid)

Opened 5 years ago

Last modified 5 years ago

[patch]changed ATTR n_regs_used[4] to use UINTVAL type in sub.pmc

Reported by: jimmy Owned by:
Priority: normal Milestone:
Component: core Version: 1.9.0
Severity: medium Keywords:
Cc: Language:
Patch status: Platform:

Description

this fixed a warning in coroutine.pmc, because ATTR n_regs_used[4] in callcontext is using UINTVAL too.

Attachments

tt1397.patch Download (3.5 KB) - added by jimmy 5 years ago.
this patch fix a waring occured in the patch of TT #1396

Change History

Changed 5 years ago by jimmy

this patch fix a waring occured in the patch of TT #1396

Changed 5 years ago by jkeenan

  • component changed from none to core

Is this patch needed only on the assumption that the patch in TT #1396 is applied?

If so, wouldn't it be better to revise the patch submitted in that ticket, rather than to create a new ticket?

Thank you very much.
kid51

Changed 5 years ago by jimmy

nope, you can applie it without TT #1396.

Changed 5 years ago by jimmy

nope, you can apply it without TT #1396.

Changed 5 years ago by bacek

  • status changed from new to closed
  • resolution set to invalid

Sorry, but this patch is invalid. To change Sub to store UINTVAL we have to change all other occurrences of INTVAL vs UINTVAL. E.g. Parrot_allocate_context, etc.

Note: See TracTickets for help on using tickets.