Ticket #1402 (closed cage: fixed)

Opened 11 years ago

Last modified 10 years ago

Deprecate mem_internal_*alloc functions.

Reported by: bacek Owned by: Paul C. Anagnostopoulos
Priority: normal Milestone:
Component: core Version: trunk
Severity: medium Keywords:
Cc: bacek Language:
Patch status: applied Platform:

Description

Currently mem_sys_* allocate functions differ from sys_internal_* only by amount of debugging info (under #ifdef DETAILED_MEMORY_DEBUG). To reduce complexity it's better to merge those two sets of functions into single one.

Attachments

PCA-patch-002.patch Download (7.3 KB) - added by Paul C. Anagnostopoulos 10 years ago.

Change History

follow-up: ↓ 2   Changed 11 years ago by bacek

If no one complain I'll do it in next couple of days.

in reply to: ↑ 1   Changed 10 years ago by jkeenan

  • cc bacek added

Replying to bacek:

If no one complain I'll do it in next couple of days.

bacek,

Have you been able to make any progress on this?

Thank you very much.

kid51

  Changed 10 years ago by Paul C. Anagnostopoulos

  • status changed from new to assigned
  • owner set to Paul C. Anagnostopoulos

I'll take this one, since I've been looking at memory management anyway. Does everyone agree that the extra debugging information provided by the mem_internal_* macros is not needed?

Changed 10 years ago by Paul C. Anagnostopoulos

  Changed 10 years ago by Paul C. Anagnostopoulos

  • patch set to new

The mem_internal_* macros have been rewritten to use the much more prevalent mem_sys_* memory functions. This leaves the mem__internal_* memory functions unused, so they were eliminated. The alloc_memory.c file is now about half the size it was.

  Changed 10 years ago by cotto

After running headerizer, all tests pass and everything appears to be in order. It sounds like this patch can be applied whenever someone with a commit bit has tuits.

  Changed 10 years ago by bubaflub

  • status changed from assigned to closed
  • resolution set to fixed
  • patch changed from new to applied

Applied in r48358

Note: See TracTickets for help on using tickets.