Ticket #1418 (new todo)

Opened 5 years ago

Last modified 3 years ago

t/src/checkdepend.t should verify PIR/PBC dependencies

Reported by: jkeenan Owned by: cotto
Priority: minor Milestone:
Component: testing Version: 2.0.0
Severity: low Keywords:
Cc: cotto Language:
Patch status: Platform:

Description (last modified by coke) (diff)

We need to verify our .pir build dependencies in the same way way we do our .c deps.

(Some of this code was in the original version in tools/dev/checkdepend.pl but was removed as it was not fully baked.

Current version is testing (and passing) all c deps.

Change History

follow-up: ↓ 3   Changed 5 years ago by cotto

To avoid creating yet another uncloseable ticket, this tt can be closed once tools/dev/checkdepends.pl is smart enough to ignore any .include directives or load_bytecode instructions that appear in heredocs in pir code.

The aforementioned fine-tuning (or reworking) of checkdepends is a general goal. As such it doesn't make for a closeable ticket.

  Changed 5 years ago by cotto

  • owner changed from Coke to cotto

in reply to: ↑ 1 ; follow-up: ↓ 4   Changed 5 years ago by jkeenan

Replying to cotto:

To avoid creating yet another uncloseable ticket, this tt can be closed once tools/dev/checkdepends.pl is smart enough to ignore any .include directives or load_bytecode instructions that appear in heredocs in pir code.

I know there has been subsequent work on tools/dev/checkdepends.pl. Is that program now smart enough to meet the conditions for closing this ticket?

Thank you very much.

kid51

in reply to: ↑ 3 ; follow-up: ↓ 6   Changed 4 years ago by jkeenan

  • cc cotto added

Replying to jkeenan:

Replying to cotto:

To avoid creating yet another uncloseable ticket, this tt can be closed once tools/dev/checkdepends.pl is smart enough to ignore any .include directives or load_bytecode instructions that appear in heredocs in pir code.

I know there has been subsequent work on tools/dev/checkdepends.pl. Is that program now smart enough to meet the conditions for closing this ticket?

Repeating question. cotto, can you provide update? Thanks.

Thank you very much. kid51

  Changed 4 years ago by coke

  • description modified (diff)
  • summary changed from tools/dev/checkdepend.pl: TODO; fine-tuning to t/src/checkdepend.t should verify PIR/PBC dependencies

updated summary/description to match the last bit of this that was left.

in reply to: ↑ 4   Changed 3 years ago by jkeenan

Replying to jkeenan:

Repeating question. cotto, can you provide update? Thanks.

Thank you very much.

cotto,

Could we get an update on the status of this ticket?

Thank you very much.

kid51

  Changed 3 years ago by coke

There is no update. no changes have been made to the test, no comments made in trac. still should be done eventually.

Note: See TracTickets for help on using tickets.