Ticket #1452 (closed cage: fixed)

Opened 5 years ago

Last modified 4 years ago

add method debug to $conf object

Reported by: coke Owned by: jkeenan
Priority: minor Milestone:
Component: configure Version: trunk
Severity: low Keywords:
Cc: Language:
Patch status: applied Platform:

Description

All the verbose handling in the config steps is keyed off:

$conf->options->get('verbose')

and then this is tested before printing:

        print "Currently we only set warnings if using gcc as C compiler\n"
            if $verbose;

Instead, just define a method on the $conf object and use that:

$conf->debug("Currently we only set warnings if using gcc as C compiler\n");

This would also obviate the need to pass the flag around to all the helper functions, since we're already passing the configure object itself.

Change History

  Changed 5 years ago by jkeenan

  • owner set to jkeenan
  • status changed from new to assigned

  Changed 4 years ago by jkeenan

  • patch set to applied

tt1452_configure_debug branch opened to work on this ticket. Work begun. Most configuration steps have been modified; some remain. No tests altered yet.

follow-up: ↓ 4   Changed 4 years ago by jkeenan

Branch was merged into trunk with r47319.

Since I was spending a lot of time looking at the configuration system, I took this as an opportunity to reduce the number of configuration steps by one. config/auto/extra_nci_thunks.pm checked whether a command-line option had been set. It did not conduct an automated probe of the user's system, which is what auto steps are supposed to do. I merely moved the functionality for checking that command-line option to config/init/defaults.pm and tested it in the corresponding test file.

Will keep ticket open for a few days for any comments or complaints.

Thank you very much.

kid51

in reply to: ↑ 3   Changed 4 years ago by jkeenan

  • status changed from assigned to closed
  • resolution set to fixed

Replying to jkeenan:

Will keep ticket open for a few days for any comments or complaints.

Hearing no complaints, I'm closing this ticket. Thank you very much.

kid51

Note: See TracTickets for help on using tickets.