Ticket #1457 (closed cage: fixed)

Opened 5 years ago

Last modified 5 years ago

remove --cxx option to Configure.pl

Reported by: coke Owned by: jkeenan
Priority: normal Milestone:
Component: configure Version: trunk
Severity: medium Keywords:
Cc: Language:
Patch status: Platform:

Description

This option appears to be a remnant from when we included ICU in core and built it ourselves.

Specifying it has no impact on the parrot build. Comments in config/init/defaults.pm hint at the original ICU purpose of this flag.

Attachments

remove_cxx.diff Download (4.7 KB) - added by coke 5 years ago.
patch to remove -cxx option
modified_remove_cxx.diff Download (5.0 KB) - added by jkeenan 5 years ago.
Coke's patch modified to remove one more instance of 'cxx'

Change History

  Changed 5 years ago by coke

  • summary changed from remove -cxx option to Configure.pl to remove --cxx option to Configure.pl

  Changed 5 years ago by coke

  • owner set to coke

Changed 5 years ago by coke

patch to remove -cxx option

follow-up: ↓ 4   Changed 5 years ago by coke

  • owner changed from coke to jkeenan
  • component changed from none to configure

Attached a patch which seems to do the job; Unfortunately, after applying the patch, t/steps/inter/progs-04.t fails.

Assigning to our configure test expert to figure out why.

in reply to: ↑ 3   Changed 5 years ago by jkeenan

  • status changed from new to assigned

Replying to coke:

Attached a patch which seems to do the job; Unfortunately, after applying the patch, t/steps/inter/progs-04.t fails.

I think all that was lacking was that cxx was not deleted from one location in that test file. When I did the following:

Index: t/steps/inter/progs-04.t
===================================================================
--- t/steps/inter/progs-04.t	(revision 45319)
+++ t/steps/inter/progs-04.t	(working copy)
@@ -56,7 +56,6 @@
         linkflags
         ldflags
         libs
-        cxx
     |
     )
 {

... the test passed.

Changed 5 years ago by jkeenan

Coke's patch modified to remove one more instance of 'cxx'

  Changed 5 years ago by jkeenan

Coke: If the modified patch works for you, you can apply and close TT.

Thanks.

kid51

  Changed 5 years ago by bubaflub

  • status changed from assigned to closed
  • resolution set to fixed

modified_remove_cxx.diff applied in r45323

Note: See TracTickets for help on using tickets.