Ticket #147 (closed patch: fixed)

Opened 6 years ago

Last modified 6 years ago

Remove unused (and broken?) real_self code

Reported by: donaldh Owned by: whiteknight
Priority: normal Milestone:
Component: core Version:
Severity: medium Keywords:
Cc: Language:
Patch status: applied Platform: all

Description

This patch removes real_self and all remaining references.

The real_self pointer in struct PMC appears to no longer be used for anything. There is redundant code in dod.c for marking the pointed to PMC but no code to set it to anything other than self.

The pointer gets clobbered during ops like clone() where the PMC header gets copied using memcpy.

See IRC discussion for history.

 http://irclog.perlgeek.de/parrot/2009-01-09#i_818271

Attachments

real_self.patch Download (1.7 KB) - added by donaldh 6 years ago.

Change History

Changed 6 years ago by donaldh

Oops, I accidentally included the smallobject.c patch in this patch. I raised a separate ticket #148 for that.

Changed 6 years ago by donaldh

Changed 6 years ago by whiteknight

  • status changed from new to assigned
  • component changed from none to core
  • patch set to new
  • platform set to all
  • owner set to whiteknight
  • type changed from bug to patch

This patch doesn't appear to affect building or testing. I have two more platforms I want to test it on later tonight (just in case), but I don't think there are any major issues with this.

If nobody has any objections, I would like to apply this patch sometime this weekend.

Changed 6 years ago by whiteknight

  • status changed from assigned to closed
  • resolution set to fixed
  • patch changed from new to applied
Note: See TracTickets for help on using tickets.