Ticket #1501 (closed bug: fixed)

Opened 5 years ago

Last modified 5 years ago

parrotthread.pmc - PMC has attributes but no auto_attrs or manual_attrs

Reported by: mikehh Owned by: NotFound
Priority: normal Milestone:
Component: build Version: 2.1.0
Severity: medium Keywords:
Cc: Language:
Patch status: Platform:

Description

In the build a warning is generated which I had not seen before

checking my build logs I found that it occurred at r43562 and after, but not at r44535

there was a change to lib/parrot/Pmc2c/PMCEmitter.pm at r44537

the last change to src/pmc/parrotthread.pmc was at r44247

...
/usr/local/bin/perl tools/build/pmc2c.pl --c  src/pmc/parrotthread.pmc
PMC has attributes but no auto_attrs or manual_attrs at /home/mhb/parrot/tools/build/../../lib/Parrot/Pmc2c/PMCEmitter.pm line 744.
/usr/local/bin/perl tools/build/c2str.pl src/pmc/parrotthread.c > src/pmc/parrotthread.str
...

I am not sure of its significance, but thought I would report it.

All tests PASS (pre/post-config, make corevm/make coretest, smoke (#32524), fulltest) at r44685 - Ubuntu 9.10 amd64 (g++ with --optimize)

Change History

Changed 5 years ago by NotFound

  • owner set to NotFound
  • status changed from new to assigned

r44357 introduces the new attribute manual_attrs, with the long-term goal of making auto_attrs the default. As first step, it warns when none of manual or auto is specified. Minor changes like adding or removing attributes or vtable init can trigger the warning.

I'll look at the recent changes in parrotthread and parrotinterpreter as soon as I can.

Changed 5 years ago by NotFound

  • status changed from assigned to closed
  • resolution set to fixed

ParrotThread init vtable function invokes SUPER and his parent is manual, so it must have the manual_attrs flag set. Done in 144771, closing.

Note: See TracTickets for help on using tickets.