Ticket #155 (closed cage: fixed)

Opened 6 years ago

Last modified 5 years ago

Remove unused function Parrot_get_namespace_autobase

Reported by: coke Owned by: whiteknight
Priority: normal Milestone: 1.5
Component: core Version:
Severity: medium Keywords:
Cc: jkeenan Language:
Patch status: Platform:

Description

The function Parrot_get_namespace_autobase in src/globals.c is never used and should be considered for deletion.

Change History

  Changed 6 years ago by whiteknight

  • owner set to whiteknight
  • status changed from new to assigned

What's the status of this request? Are we able to delete this unused function or not? If this function is actually intended to be used (such as through the embedding interface) we should write up an example that uses it.

  Changed 6 years ago by coke

If C functions fall under our normal deprecation guidelines (recent evidence to the contrary ignored for the moment), then we probably can't remove it without a RELEASE of it listed in the DEPRECATION file.)

  Changed 6 years ago by whiteknight

I was under the impresion that deprecation notices were only being used for PIR-facing interface changes, and not for internals. Do we need a deprecation cycle for this?

  Changed 6 years ago by coke

Not PIR-facing, but user-visible.

Given the spongy nature of what PARROT_API and PARROT_EXPORT currently mean, and that all the internals are exposed to HLL authors writing PMCs, there's at least a need to resolve the question as to what we can remove without notice. (especially as 1.0 approaches)

  Changed 5 years ago by whiteknight

  • milestone set to 1.5

Added this to DEPRECATED.pod in r38351. We can remove it after v1.5, if nobody has an objection before then.

  Changed 5 years ago by jkeenan

As a reference, here is where I currently (r39228) find mention of Parrot_get_namespace_autobase:

./src/global.c:392:=item C<PMC * Parrot_get_namespace_autobase(PARROT_INTERP, PMC *key)>
./src/global.c:407:Parrot_get_namespace_autobase(PARROT_INTERP, ARGIN_NULLOK(PMC *key))
./src/global.c:409:    ASSERT_ARGS(Parrot_get_namespace_autobase)
./include/parrot/global.h:81:PMC * Parrot_get_namespace_autobase(PARROT_INTERP, ARGIN_NULLOK(PMC *key))
./include/parrot/global.h:177:#define ASSERT_ARGS_Parrot_get_namespace_autobase __attribute__unused__ int _ASSERT_ARGS_CHECK = \
./DEPRECATED.pod:227:=item Parrot_get_namespace_autobase [eligible in 1.5]

  Changed 5 years ago by jkeenan

  • cc jkeenan added

  Changed 5 years ago by jkeenan

  • component changed from none to core

in reply to: ↑ description   Changed 5 years ago by bacek

  • status changed from assigned to closed
  • resolution set to fixed

Replying to coke:

The function Parrot_get_namespace_autobase in src/globals.c is never used and should be considered for deletion.

Function removed in r40186. Closing ticket.

-- Bacek

Note: See TracTickets for help on using tickets.