Ticket #156 (closed cage: done)

Opened 11 years ago

Last modified 11 years ago

remove unused function Parrot_find_global_k

Reported by: coke Owned by: whiteknight
Priority: normal Milestone: 1.5
Component: core Version:
Severity: medium Keywords:
Cc: jkeenan Language:
Patch status: Platform:

Description

The function Parrot_find_global_k in src/globals.c is never used and should be considered for deletion.

Change History

  Changed 11 years ago by NotFound

This function is documented in docs/embed.pod, so it makes sense is present even with never used by parrot core.

  Changed 11 years ago by whiteknight

  • owner set to whiteknight
  • status changed from new to assigned
  • component changed from none to core
  • milestone set to 1.0

So what's the final verdict on this issue? Is Parrot_find_global_k going to be a permanent part of our embedding API, or not? If so, we should probably work up a test/example that makes use of it. If not, I'll delete it.

  Changed 11 years ago by whiteknight

Added this to DEPRECATED.pod in r38351. We can remove it after v1.5, if nobody has an objection before then.

  Changed 11 years ago by whiteknight

  • milestone changed from 1.1 to 1.5

  Changed 11 years ago by jkeenan

  • cc jkeenan added

As a reference, here is where I currently (r39228) find Parrot_find_global_k:

./src/global.c:574:=item C<PMC * Parrot_find_global_k(PARROT_INTERP, PMC *pmc_key, STRING
./src/global.c:592:Parrot_find_global_k(PARROT_INTERP, ARGIN_NULLOK(PMC *pmc_key), ARGIN(STRING *globalname))
./src/global.c:594:    ASSERT_ARGS(Parrot_find_global_k)
./docs/embed.pod:350:=item C<Parrot_PMC Parrot_find_global_k(PARROT_INTERP, Parrot_PMC namespace_key, Parrot_String name)>
./include/parrot/global.h:29:PMC * Parrot_find_global_k(PARROT_INTERP,
./include/parrot/global.h:162:#define ASSERT_ARGS_Parrot_find_global_k __attribute__unused__ int _ASSERT_ARGS_CHECK = \
./DEPRECATED.pod:231:=item Parrot_find_global_k [eligible in 1.5]

in reply to: ↑ description   Changed 11 years ago by bacek

  • status changed from assigned to closed
  • resolution set to done

Replying to coke:

The function Parrot_find_global_k in src/globals.c is never used and should be considered for deletion.

Function removed in r40187. Closing ticket.

-- Bacek

Note: See TracTickets for help on using tickets.