remove unused function Parrot_find_global_k

[coke]

The function Parrot_find_global_k in src/globals.c is never used and should be considered for deletion.

[NotFound]

This function is documented in docs/embed.pod, so it makes sense is present even with never used by parrot core.

[whiteknight]

So what's the final verdict on this issue? Is Parrot_find_global_k going to be a permanent part of our embedding API, or not? If so, we should probably work up a test/example that makes use of it. If not, I'll delete it.

[coke]

See https://trac.parrot.org/parrot/ticket/155#comment:2

[whiteknight]

Added this to DEPRECATED.pod in r38351. We can remove it after v1.5, if nobody has an objection before then.

[jkeenan]

As a reference, here is where I currently (r39228) find Parrot_find_global_k:

./src/global.c:574:=item C<PMC * Parrot_find_global_k(PARROT_INTERP, PMC *pmc_key, STRING
./src/global.c:592:Parrot_find_global_k(PARROT_INTERP, ARGIN_NULLOK(PMC *pmc_key), ARGIN(STRING *globalname))
./src/global.c:594:    ASSERT_ARGS(Parrot_find_global_k)
./docs/embed.pod:350:=item C<Parrot_PMC Parrot_find_global_k(PARROT_INTERP, Parrot_PMC namespace_key, Parrot_String name)>
./include/parrot/global.h:29:PMC * Parrot_find_global_k(PARROT_INTERP,
./include/parrot/global.h:162:#define ASSERT_ARGS_Parrot_find_global_k __attribute__unused__ int _ASSERT_ARGS_CHECK = \
./DEPRECATED.pod:231:=item Parrot_find_global_k [eligible in 1.5]

[bacek]

Replying to coke:

The function Parrot_find_global_k in src/globals.c is never used and should be considered for deletion.

Function removed in r40187. Closing ticket.

-- Bacek