Ticket #158 (closed todo: done)

Opened 6 years ago

Last modified 5 years ago

deprecated: :anon and :vtable named parameters to add_method

Reported by: coke Owned by: NotFound
Priority: major Milestone: 1.3
Component: none Version:
Severity: medium Keywords:
Cc: Language:
Patch status: applied Platform: all

Description

From DEPRECATED.pod

=item * :anon and :vtable named parameters to add_method [post 0.8.2]

If you want to override a vtable method/function when building a Class, then
use the method C<add_vtable_override> instead of calling C<add_method> with
one or both of these flags.

Attachments

remove-add_method-parameters Download (2.5 KB) - added by kraai 6 years ago.
Patch

Change History

Changed 6 years ago by coke

Jonathan: can you expand on this item so we can rip it out for 0.9.0 ? Thanks.

Changed 6 years ago by coke

  • type changed from bug to todo

Changed 6 years ago by whiteknight

  • platform set to all

If I understand this correctly (and please correct me if I'm wrong), we want to check for :anon and :vtable flags on a method in src/pmc/class:VTABLE_add_method(). Subs with :vtable should not be added as a vtable override when you call add_method, they should only be added as an override when you call src/pmc/class.pmc:METHOD_add_vtable_override.

Is this correct?

In either case, I don't think this is getting done before tomorrow's release.

Changed 6 years ago by kraai

Patch

Changed 6 years ago by kraai

Among other things, the patch changes the test case uses of add_method with the vtable parameter to add_vtable_override. It doesn't preserve the calls to add_method, however, which is a slight change of behavior.

Changed 5 years ago by NotFound

  • status changed from new to assigned
  • owner set to NotFound
  • patch set to applied

Patch applied in r39122. I'll close the ticket in a few days if there are no objections.

Changed 5 years ago by NotFound

  • status changed from assigned to closed
  • resolution set to done

No objections in 3 weeks, closing ticket.

Note: See TracTickets for help on using tickets.