Ticket #1655 (closed deprecation: done)

Opened 3 years ago

Last modified 2 years ago

[DEPRECATED] logical vtables

Reported by: plobsing Owned by: plobsing
Priority: normal Milestone:
Component: core Version: 2.4.0
Severity: medium Keywords:
Cc: Language:
Patch status: Platform:

Description

Logical values in parrot are INTVALs. We shouldn't need vtables and ops to perform these on PMCs. Use of 'get_bool' and intval ops should replace these.

Change History

  Changed 3 years ago by bacek

+1

in reply to: ↑ description   Changed 3 years ago by plobsing

  • owner set to plobsing
  • type changed from RFC to deprecation
  • summary changed from [RFC] deprecate logical vtables to [DEPRECATED] logical vtables

Replying to plobsing:

Logical values in parrot are INTVALs. We shouldn't need vtables and ops to perform these on PMCs. Use of 'get_bool' and intval ops should replace these.

Near-total warnoxing of this ticket is assumed to be consent. Deprecating.

  Changed 3 years ago by luben

At r49012 Logical VTABLES are removed. Logical Ops on PMC are converted to use VTABLE_get_bool() internally.

  Changed 3 years ago by luben

Rakudo seems to depend on logical ops on PMC. So I am leaving them.

follow-up: ↓ 6   Changed 3 years ago by jkeenan

  • component changed from none to core

plobsing, luben:

We discussed this ticket in #parrotsketch today, as it is listed in DEPRECATED.pod as an item which can be implemented in Parrot 2.10 or later. So it's now okay to do the revisions described in this ticket -- provided you still think we should be doing them. But luben's last comment suggests that perhaps we shouldn't be doing anything more on this ticket.

Could you review the issues and clarify?

Thank you very much.

kid51

in reply to: ↑ 5   Changed 2 years ago by plobsing

  • status changed from new to closed
  • resolution set to done

Replying to jkeenan:

plobsing, luben: We discussed this ticket in #parrotsketch today, as it is listed in DEPRECATED.pod as an item which can be implemented in Parrot 2.10 or later. So it's now okay to do the revisions described in this ticket -- provided you still think we should be doing them. But luben's last comment suggests that perhaps we shouldn't be doing anything more on this ticket. Could you review the issues and clarify? Thank you very much. kid51

The logical ops on PMCs are much less costly than the vtables themselves. While it would be nice to be rid of them from a purity perspective, it seems sufficient to have removed the vtables. Closing ticket.

Note: See TracTickets for help on using tickets.