Ticket #1680 (closed bug: fixed)
t/steps/gen/opengl-01.t: Tests for verbose output fail when OpenGL not present
Reported by: | jkeenan | Owned by: | jkeenan |
---|---|---|---|
Priority: | normal | Milestone: | |
Component: | configure | Version: | 2.4.0 |
Severity: | medium | Keywords: | |
Cc: | Language: | ||
Patch status: | applied | Platform: |
Description
While testing Parrot today on a box on which OpenGL is not installed, I got failures in t/steps/gen/opengl-01.t in tests for verbose output. I had not previously encountered these failures because the two machines on which I regularly test Parrot both have OpenGL installed.
gen::opengl::runstep() is quite complex and it is difficult to write tests which mock all the branches and conditions inside it. The tests for verbose output are not very relevant when has_opengl is false. So I think it would be best to simply SKIP some tests rather than jump through hoops mocking them.
The patch attached implements this correction, but I'm going to hold off until after the release to apply it.
Thank you very much.
kid51