Ticket #1680 (closed bug: fixed)

Opened 5 years ago

Last modified 5 years ago

t/steps/gen/opengl-01.t: Tests for verbose output fail when OpenGL not present

Reported by: jkeenan Owned by: jkeenan
Priority: normal Milestone:
Component: configure Version: 2.4.0
Severity: medium Keywords:
Cc: Language:
Patch status: applied Platform:

Description

While testing Parrot today on a box on which OpenGL is not installed, I got failures in t/steps/gen/opengl-01.t in tests for verbose output. I had not previously encountered these failures because the two machines on which I regularly test Parrot both have OpenGL installed.

gen::opengl::runstep() is quite complex and it is difficult to write tests which mock all the branches and conditions inside it. The tests for verbose output are not very relevant when has_opengl is false. So I think it would be best to simply SKIP some tests rather than jump through hoops mocking them.

The patch attached implements this correction, but I'm going to hold off until after the release to apply it.

Thank you very much.

kid51

Attachments

t.steps.gen.opengl.patch Download (4.5 KB) - added by jkeenan 5 years ago.
Patch to skip some tests in t/steps/gen/opengl-01.t when OpenGL not really present

Change History

Changed 5 years ago by jkeenan

Patch to skip some tests in t/steps/gen/opengl-01.t when OpenGL not really present

Changed 5 years ago by jkeenan

  • owner set to jkeenan
  • status changed from new to assigned

Changed 5 years ago by jkeenan

  • status changed from assigned to closed
  • resolution set to fixed
  • patch changed from new to applied

Fixed in r47649. Closing.

Note: See TracTickets for help on using tickets.