Ticket #1683 (new todo)

Opened 4 years ago

Last modified 4 years ago

Key clone and set_pmc are broken

Reported by: NotFound Owned by:
Priority: normal Milestone:
Component: none Version: 2.5.0
Severity: medium Keywords:
Cc: Language:
Patch status: Platform:

Description

The VTABLEs clone and set_pmc in the Key PMC uses the function key_set_pmc, and that function just throws with a message referring to a nonexistent slice.pmc and has a comment: "XXX leo - what for is this indirection?"

The key_set_pmc isn't used anywhere else and its name doesn't follow the naming convention, so is already deprecated. I'm going to delete it and replace its usage in Hash with throwing an exception with a message referring this ticket.

Change History

Changed 4 years ago by NotFound

Cleanup done in r47710, the TODO is now just to fix the Key VTABLEs.

Note: See TracTickets for help on using tickets.