Ticket #1715 (closed bug: fixed)

Opened 4 years ago

Last modified 4 years ago

pprof2cg.pl not installed

Reported by: coke Owned by: jkeenan
Priority: normal Milestone:
Component: install Version: 2.5.0
Severity: medium Keywords:
Cc: Language:
Patch status: applied Platform:

Description

trying to do some profiling testing, I noticed that tools/dev/pprof2cg.pl isn't available in my installed parrot directory.

Attachments

install_pprof2cg.pl.diff Download (1.6 KB) - added by jkeenan 4 years ago.

Change History

in reply to: ↑ description ; follow-up: ↓ 2   Changed 4 years ago by jkeenan

Replying to coke:

trying to do some profiling testing, I noticed that tools/dev/pprof2cg.pl isn't available in my installed parrot directory.

Where would you expect tools/dev/pprof2cg.pl to be installed?

For reference, here's what I see as the top level of an installation using --prefix:

[li11-226:pseudoinstall] 516 $ ll
total 5
drwxr-xr-x 2 jimk jimk 1024 Jul 27 19:21 bin
drwxr-xr-x 3 jimk jimk 1024 Jul 27 19:21 include
drwxr-xr-x 4 jimk jimk 1024 Jul 27 19:21 lib
drwxr-xr-x 3 jimk jimk 1024 Jul 27 19:21 share
drwxr-xr-x 3 jimk jimk 1024 Jul 27 19:21 src

kid51

in reply to: ↑ 1   Changed 4 years ago by jkeenan

Replying to jkeenan:

Replying to coke:

trying to do some profiling testing, I noticed that tools/dev/pprof2cg.pl isn't available in my installed parrot directory.

Where would you expect tools/dev/pprof2cg.pl to be installed?

To answer my own question, presumably along side these programs:

[li11-226:pseudoinstall] 518 $ find . -type f -name '*.pl'
./lib/parrot/2.6.0-devel/tools/build/ops2c.pl
./lib/parrot/2.6.0-devel/tools/build/pmc2c.pl
./lib/parrot/2.6.0-devel/tools/dev/create_language.pl
./lib/parrot/2.6.0-devel/tools/dev/gen_makefile.pl
./lib/parrot/2.6.0-devel/tools/dev/mk_language_shell.pl
./lib/parrot/2.6.0-devel/tools/dev/reconfigure.pl

follow-up: ↓ 4   Changed 4 years ago by jkeenan

  • owner set to jkeenan
  • status changed from new to assigned
  • patch set to new

Coke:

Attaching a patch. Does it work for you?

Note: I would have gone ahead and directly applied it to trunk, but I noticed that in the checkout tools/dev/pprof2cg.pl is set to be executable (0755), so it gets installed as 0755 as well. The other .pl files that sit in ./lib/parrot/2.6.0-devel/tools/dev/ are all 0644. Can you/anyone advise as to what would be best?

Thank you very much.

kid51

Changed 4 years ago by jkeenan

in reply to: ↑ 3   Changed 4 years ago by coke

Replying to jkeenan:

Coke: Attaching a patch. Does it work for you? Note: I would have gone ahead and directly applied it to trunk, but I noticed that in the checkout tools/dev/pprof2cg.pl is set to be executable (0755), so it gets installed as 0755 as well. The other .pl files that sit in ./lib/parrot/2.6.0-devel/tools/dev/ are all 0644. Can you/anyone advise as to what would be best? Thank you very much. kid51

untested, but looks reasonable. I'd probably make them all executable and point the shebangs to #!env perl, or something equally vanilla.

  Changed 4 years ago by jkeenan

  • patch changed from new to applied

I applied a patch in r48246. I will keep the ticket open for a few days to register any complaints.

I also deleted the svn:executable property on tools/dev/pprof2cg.pl. The program as it currently exists starts with #! perl -- which I understand not to be a valid shebang line -- and its documentation says it is to be called thus:

perl tools/dev/pprof2cg.pl parrot.pprof.1234

So I don't think it needs to be executable either in the distro or in an installation.

The larger question of which files should be executable has been moved to the parrot-dev list, where lively discussion ensues.

Thank you very much.

kid51

  Changed 4 years ago by jkeenan

  • status changed from assigned to closed
  • resolution set to fixed

No complaints registered. Closing ticket.

Note: See TracTickets for help on using tickets.