Ticket #1721 (closed bug: fixed)

Opened 4 years ago

Last modified 4 years ago

parrot version numbers in oplib

Reported by: NotFound Owned by:
Priority: normal Milestone:
Component: none Version: 2.6.0
Severity: medium Keywords:
Cc: Language:
Patch status: Platform:

Description

In r48214 I've noticed that executing make bootstrap-ops updated the parrot version number in core_ops.c

We should add a note in the release manager guide about the steps needed to get that numbers updated, and a way to test it.

Or alternatively, delete that fields from the oplib struct. Are they used or intended to use for something? ack doesn't show me anything relevant.

Change History

Changed 4 years ago by cotto

I've updated opsc (and ops2c, which uses opsc) to read the version number from the VERSION file and updated the release manager guide accordingly. Updating the version is now automated (after editing VERSION itself) and definitely doesn't involve editing any generated files.

If this fixes NotFound's original issue, this ticket can be closed.

Changed 4 years ago by NotFound

Will be nice to have a test verifying that the numbers in the generated files match VERSION.

Changed 4 years ago by cotto

VERSION is a trivial file. I can see the sense in having a test somewhere to make sure it's in the right format, but the code to process its contents consists entirely of split(). Adding a test to make sure that periods are successfully split on doesn't strike me as being particularly likely to catch any errors. If I'm misinterpreting you and there's some kind of error such a test is likely to catch, I'd be glad to add one.

Changed 4 years ago by NotFound

I don't mean testing the VERSION file by itself, but checking that it contents match the numbers in the C files generated from ops, to be sure they were regenerated after VERSION change.

Changed 4 years ago by cotto

  • status changed from new to closed
  • resolution set to fixed

I added such a test in r48731 so I'll make this ticket closed.

Note: See TracTickets for help on using tickets.