Ticket #1726 (assigned todo)
Missing POD in .pmc files (and a couple of others)
Reported by: | mikehh | Owned by: | jkeenan |
---|---|---|---|
Priority: | normal | Milestone: | |
Component: | coding_standards | Version: | trunk |
Severity: | medium | Keywords: | |
Cc: | Language: | ||
Patch status: | applied | Platform: |
Description
We recently completed an exercise whereby the coding standard test t/codingstd/c_function_docs.t and the associated documentation was fixed so that no TODO's remain for missing POD in c functions in parrot.
I had occasion to run make headerizer and found that it reported missing POD in some other files, mostly .pmc files and one .y file (plus 3 .c files from compilers/src/pirc not tested by c_function_docs.t).
It is suggested that .pmc files be included in c_function_docs.t or possibly in a new test.
at r48245 make headerizer furnishes the following output:
compilers/imcc/imcc.y: adv_named_set_u has no POD compilers/pirc/src/main.c: process_file has no POD compilers/pirc/src/pircompunit.c: set_sub_multi_types has no POD compilers/pirc/src/pirparser.c: YYID has no POD src/pmc/bigint.pmc: bigint_init has no POD src/pmc/bigint.pmc: bigint_clear has no POD src/pmc/bigint.pmc: bigint_set has no POD src/pmc/bigint.pmc: bigint_set_str has no POD src/pmc/bigint.pmc: bigint_get_self has no POD src/pmc/bigint.pmc: bigint_set_self has no POD src/pmc/bigint.pmc: bigint_get_long has no POD src/pmc/bigint.pmc: bigint_get_bool has no POD src/pmc/bigint.pmc: bigint_get_string has no POD src/pmc/bigint.pmc: bigint_get_double has no POD src/pmc/bigint.pmc: bigint_add_bigint has no POD src/pmc/bigint.pmc: bigint_add_bigint_int has no POD src/pmc/bigint.pmc: bigint_sub_bigint has no POD src/pmc/bigint.pmc: bigint_sub_bigint_int has no POD src/pmc/bigint.pmc: bigint_mul_bigint has no POD src/pmc/bigint.pmc: bigint_mul_bigint_int has no POD src/pmc/bigint.pmc: bigint_pow_bigint_int has no POD src/pmc/bigint.pmc: int_check_divide_zero has no POD src/pmc/bigint.pmc: bigint_check_divide_zero has no POD src/pmc/bigint.pmc: bigint_div_bigint has no POD src/pmc/bigint.pmc: bigint_div_bigint_int has no POD src/pmc/bigint.pmc: bigint_fdiv_bigint has no POD src/pmc/bigint.pmc: bigint_fdiv_bigint_int has no POD src/pmc/bigint.pmc: bigint_mod_bigint has no POD src/pmc/bigint.pmc: bigint_mod_bigint_int has no POD src/pmc/bigint.pmc: bigint_cmp has no POD src/pmc/bigint.pmc: bigint_cmp_int has no POD src/pmc/bigint.pmc: bigint_abs has no POD src/pmc/bigint.pmc: bigint_neg has no POD src/pmc/callcontext.pmc: ensure_positionals_storage has no POD src/pmc/callcontext.pmc: ensure_positionals_storage_ap has no POD src/pmc/callcontext.pmc: get_cell_at has no POD src/pmc/callcontext.pmc: autobox_intval has no POD src/pmc/callcontext.pmc: autobox_floatval has no POD src/pmc/callcontext.pmc: autobox_string has no POD src/pmc/callcontext.pmc: autobox_pmc has no POD src/pmc/callcontext.pmc: get_hash has no POD src/pmc/callcontext.pmc: mark_cell has no POD src/pmc/callcontext.pmc: mark_positionals has no POD src/pmc/callcontext.pmc: mark_hash has no POD src/pmc/callcontext.pmc: get_named_names has no POD src/pmc/class.pmc: pointer_compare has no POD src/pmc/class.pmc: key_hash_pointer has no POD src/pmc/class.pmc: cache_class_attribs has no POD src/pmc/class.pmc: build_attrib_index has no POD src/pmc/class.pmc: init_class_from_hash has no POD src/pmc/class.pmc: initialize_parents has no POD src/pmc/class.pmc: initialize_parents_pmc has no POD src/pmc/class.pmc: make_class_name has no POD src/pmc/class.pmc: calculate_mro has no POD src/pmc/complex.pmc: int_check_divide_zero has no POD src/pmc/complex.pmc: float_check_divide_zero has no POD src/pmc/complex.pmc: complex_check_divide_zero has no POD src/pmc/coroutine.pmc: print_sub_name has no POD src/pmc/eval.pmc: clear_fixups has no POD src/pmc/eval.pmc: get_sub has no POD src/pmc/eval.pmc: mark_subs has no POD src/pmc/fixedintegerarray.pmc: auxcmpfunc has no POD src/pmc/hashiterator.pmc: advance_to_next has no POD src/pmc/imageio.pmc: GET_VISIT_CURSOR has no POD src/pmc/imageio.pmc: SET_VISIT_CURSOR has no POD src/pmc/imageio.pmc: INC_VISIT_CURSOR has no POD src/pmc/imageio.pmc: create_buffer has no POD src/pmc/imageio.pmc: ensure_buffer_size has no POD src/pmc/imageio.pmc: INFO_HAS_DATA has no POD src/pmc/imageio.pmc: id_list_get has no POD src/pmc/imageio.pmc: visit_todo_list_thaw has no POD src/pmc/imageio.pmc: visit_todo_list_freeze has no POD src/pmc/imageiosize.pmc: visit_todo_list_freeze has no POD src/pmc/integer.pmc: maybe_throw_overflow_error has no POD src/pmc/integer.pmc: upgrade_self_to_bignum has no POD src/pmc/namespace.pmc: add_to_class has no POD src/pmc/namespace.pmc: ns_insert_sub_keyed_str has no POD src/pmc/namespace.pmc: maybe_add_sub_to_namespace has no POD src/pmc/namespace.pmc: add_nci_to_namespace has no POD src/pmc/namespace.pmc: add_multi_to_namespace has no POD src/pmc/nci.pmc: pcc_params has no POD src/pmc/nci.pmc: build_func has no POD src/pmc/null.pmc: null_pmc_access has no POD src/pmc/object.pmc: get_attrib_index has no POD src/pmc/object.pmc: get_attrib_index_keyed has no POD src/pmc/object.pmc: find_cached has no POD src/pmc/object.pmc: cache_method has no POD src/pmc/orderedhash.pmc: get_list_item has no POD src/pmc/orderedhash.pmc: find_bounds has no POD src/pmc/orderedhash.pmc: box_string has no POD src/pmc/orderedhash.pmc: box_integer has no POD src/pmc/orderedhash.pmc: box_number has no POD src/pmc/packfile.pmc: copy_packfile_header has no POD src/pmc/role.pmc: init_role_from_hash has no POD src/pmc/sub.pmc: print_sub_name has no POD src/pmc/threadinterpreter.pmc: stop_GC has no POD Headerization complete.
Attachments
Change History
Note: See
TracTickets for help on using
tickets.