Ticket #1728 (closed patch: fixed)

Opened 4 years ago

Last modified 4 years ago

Add more signatures for for PAST op types.

Reported by: coke Owned by: pmichaud
Priority: normal Milestone:
Component: PCT Version: trunk
Severity: low Keywords:
Cc: Language: tcl
Patch status: applied Platform:

Description

Inlined.

I'll probably apply this in a few days if there are no objections.

Index: compilers/pct/src/PAST/Compiler.pir
===================================================================
--- compilers/pct/src/PAST/Compiler.pir (revision 48286)
+++ compilers/pct/src/PAST/Compiler.pir (working copy)
@@ -81,7 +81,11 @@
     piropsig['find_codepoint']   = 'Is'
     piropsig['find_dynamic_lex'] = 'Ps'
     piropsig['find_name']  = 'Ps'
+    piropsig['getinterp']  = 'P'
     piropsig['getprop']    = 'P~P'
+    piropsig['getstderr']  = 'P'
+    piropsig['getstdin']   = 'P'
+    piropsig['getstdout']  = 'P'
     piropsig['index']      = 'Issi'
     piropsig['isa']        = 'IP~'
     piropsig['isfalse']    = 'IP'
@@ -92,9 +96,11 @@
     piropsig['length']     = 'Is'
     piropsig['load_bytecode'] = 'vs'
     piropsig['load_language'] = 'vs'
+    piropsig['loadlib']    = 'P~'
     piropsig['mod']        = 'PP+'
     piropsig['mul']        = 'PP+'
     piropsig['neg']        = 'PP'
+    piropsig['new']        = 'P~'
     piropsig['newclosure'] = 'PP'
     piropsig['not']        = 'PP'
     piropsig['ord']        = 'Isi'
@@ -117,7 +123,9 @@
     piropsig['split']      = 'Pss'
     piropsig['sub']        = 'PP+'
     piropsig['substr']     = 'Ssii'
+    piropsig['titlecase']  = 'Ss'
     piropsig['trace']      = 'vi'
+    piropsig['typeof']     = '~P'
     piropsig['unshift']    = '0P*'
     piropsig['upcase']     = 'Ss'
     set_global '%piropsig', piropsig

Change History

Changed 4 years ago by pmichaud

Patch approved, with one correction:

>  +    piropsig['typeof']     = '~P'

"~" is not really a valid return type specifier -- it needs to be
an explicit register type (e.g., either 'S' or 'P').

Thanks!

Pm

Changed 4 years ago by coke

  • status changed from new to closed
  • resolution set to fixed
  • patch changed from new to applied

Fixed and applied.

Note: See TracTickets for help on using tickets.