HTTP/1.1 -1 Read error in cache disk data: SuccessContent-Type: text/tab-separated-values; charset="utf-8" Last-Modified: Sat, 22 Jan 2022 03:26:25 GMT Content-length: 931 Connection: Close Proxy-Connection: Close X-Cache: HIT from web1.osuosl.org Server: ProxyTrack 0.5 (HTTrack 3.49.2) id summary reporter owner description type status priority milestone component version severity resolution keywords cc lang patch platform 1749 readall method on open FileHandle is inefficient pmichaud "Using readall on an open filehandle appears to be extremely inefficient. Some simple tests reading a 10,000 line file can end up taking several seconds to complete. Notably, reading the filehandle line-at-a-time via 'read' is far more efficient than 'readall'. Looking at the filehandle.pmc code, it appears that 'readall' turns on line buffering on the input filehandle, and then does successive string concatenations to produce the resulting string. That involves a lot of string allocations, iiuc, which is probably part of the slowness. I'm not sure why it chooses to use line buffering -- it seems like some other strategy would be far more efficient. Pm" bug closed normal core 2.6.0 medium fixed script" src="