Ticket #1760 (closed bug: fixed)

Opened 4 years ago

Last modified 4 years ago

Spurious newline in version string

Reported by: Paul C. Anagnostopoulos Owned by: cotto
Priority: normal Milestone:
Component: library Version: 2.6.0
Severity: medium Keywords:
Cc: Language:
Patch status: Platform:

Description

When I run the tests on my Windows XP machine, I get the following error:

t\compilers\opsc\06-opsfile.t ..
...
not ok 6 # Version parsed
> <2 7 0

This is checking the version returned by Ops::File.new. Turns out it has a newline at the end, so it does not match /^\d+ \s \d+ \s \d+$/. The newline should be removed. (I added the angle brackets around the version display so it is easier to see what's happening.)

Attachments

opsc_version_fix.patch Download (1.6 KB) - added by cotto 4 years ago.

Change History

Changed 4 years ago by cotto

  • owner set to cotto

Changed 4 years ago by Paul C. Anagnostopoulos

I recommend you put angle brackets around the version output.

Changed 4 years ago by cotto

Changed 4 years ago by cotto

Does the attached patch help any?

Changed 4 years ago by Paul C. Anagnostopoulos

The patch fixes the 06-opsfile.t test and doesn't break any others.

Changed 4 years ago by cotto

  • status changed from new to closed
  • resolution set to fixed

I applied the patch in r48736 (though with an incorrect tt number). Thanks for reporting the bug and testing the patch.

Note: See TracTickets for help on using tickets.