Ticket #1774 (closed patch: fixed)

Opened 11 years ago

Last modified 11 years ago

Adding without-readline support

Reported by: ash Owned by: jkeenan
Priority: normal Milestone:
Component: configure Version: 2.6.0
Severity: medium Keywords:
Cc: Language:
Patch status: applied Platform:

Description

Here is a quick diff to add without-readline support. Its mostly a configuration issue, in that parrot currently doesn't check if you specified --without-readline at configuration time.

Attachments

parrot-configure-without-readline.diff Download (1.5 KB) - added by ash 11 years ago.
Diff for parrot configuration to add --without-readline

Change History

Changed 11 years ago by ash

Diff for parrot configuration to add --without-readline

Changed 11 years ago by jkeenan

  • status changed from new to assigned
  • owner set to jkeenan
  • component changed from none to configure

ash,

Thanks for the patch. I am studying it and hope to apply it soon. The only thing that, right off the bat, it appears to lack, is a test for the --without-readline option, which would probably go into t/steps/auto/readline-02.t. I can write that, but if you can come up with that, so much the better.  coverage analysis

You might wish to add to the DESCRIPTION section of readline.pm a brief paragraph describing the circumstances in which one would not want to configure with readline.

Thank you very much.

kid51

Thank you very much.

kid51

Changed 11 years ago by jkeenan

  • status changed from assigned to closed
  • resolution set to fixed
  • patch set to applied

Patch applied, plus additional tests in r48925.

Thank you very much.

kid51

Note: See TracTickets for help on using tickets.