Ticket #1778 (closed deprecation: fixed)

Opened 4 years ago

Last modified 4 years ago

Charset opcodes are deprecated

Reported by: nwellnhof Owned by: nwellnhof
Priority: normal Milestone: 2.10
Component: core Version: trunk
Severity: medium Keywords:
Cc: Language:
Patch status: Platform:

Description (last modified by nwellnhof) (diff)

After the charset/encoding merge, the following opcodes can be deprecated:

charset
charsetname
find_charset
trans_charset

Use the corresponding encoding opcodes instead. The list of supported encodings is:

ascii
iso-8859-1
binary
utf8
utf16
ucs2
ucs4

Use the 'utf8' encoding instead of the 'unicode' charset. The 'fixed_8' encoding is also going away. Use 'ascii' instead.

Change History

Changed 4 years ago by nwellnhof

  • description modified (diff)

Changed 4 years ago by pmichaud

Is the 'fixed_8' encoding also disappearing? If so, that deserves its own mention in DEPRECATED.pod also.

Pm

Changed 4 years ago by nwellnhof

Yes, you're right. 'fixed_8' will also disappear. I'll update the deprecation notes.

Changed 4 years ago by nwellnhof

  • description modified (diff)

Changed 4 years ago by nwellnhof

  • owner set to nwellnhof

Changed 4 years ago by nwellnhof

  • milestone set to 2.10

Changed 4 years ago by jkeenan

nwellnhof,

This ticket was discussed in #parrotsketch today. Since the next release will be Parrot 2.10, our path is now clear to implement the deprecations suggested.

Will you be able to take care of this?

Thank you very much.

kid51

Changed 4 years ago by nwellnhof

  • status changed from new to assigned

Yes, of course. There are still some very minor changes to be done in the Parrot and Rakudo codebase until we can safely remove the charset opcodes. I already have patches for that.

Changed 4 years ago by nwellnhof

The deprecated charset opcodes have been removed from Rakudo and nqp-rx. I created a branch remove_charset_ops that finally removes the ops in r49701.

I think we should wait a bit before merging it. I'll probably send another warning message to parrot-dev.

Changed 4 years ago by jkeenan

Tested remove_charset_ops on  Linux/i386: PASS Smolder

make fulltest showed 2 POD-formatting errors in ext/nqp-rx/src/stage0/HLL-s0.pir, but I believe those have been fixed in trunk.

Tested remove_charset_ops on  Darwin/PPC: PASS Smolder

You might want to post to 'parrot-users' as well.

Thank you very much.

kid51

Changed 4 years ago by nwellnhof

  • status changed from assigned to closed
  • resolution set to fixed
Note: See TracTickets for help on using tickets.